Skip to content

Use the canvas factory for worker frame contexts (PR 21860 follow-up) - #22157

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:renderer-worker-frame-context
Oct 12, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:renderer-worker-frame-context

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Use getNoAlphaContext, as main-thread rendering does, so both paths set willReadFrequently according to enableHWA.

Use getNoAlphaContext, as main-thread rendering does, so both paths set
willReadFrequently according to enableHWA.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.31%. Comparing base (68f5e21) to head (c257372).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22157   +/-   ##
=======================================
  Coverage   90.30%   90.31%           
=======================================
  Files         277      277           
  Lines       67956    67956           
=======================================
+ Hits        61367    61373    +6     
+ Misses       6589     6583    -6     
Flag Coverage Δ
browsertest 66.21% <100.00%> (-0.02%) ⬇️
fonttest 8.98% <ø> (ø)
integrationtest 69.28% <100.00%> (+<0.01%) ⬆️
unittest 60.19% <100.00%> (-0.01%) ⬇️
unittestcli 58.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing browser-tests; thanks.

@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for c257372 (run, references from mozilla/pdf.js.refs@23d8c278ca).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1393 12m 13s 0 0 0 0
Windows ⚠️ 1393 15m 53s 0 1 0 0 view differences

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@calixteman
calixteman merged commit ac9c125 into mozilla:master Oct 12, 2026
30 checks passed
@calixteman
calixteman deleted the renderer-worker-frame-context branch October 12, 2026 18:15
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026

This branch was previously deployed

1 inactive deployment
sync_pdfs — c257372d Deployed Oct 12, 2026 by Snuffleupagus via request #373
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants