Skip to content

Report PDF modifications to Firefox (bug 2076546) - #22162

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:firefox-download-is-modified
Oct 12, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:firefox-download-is-modified

Conversation

@calixteman

@calixteman calixteman commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Pass an isModified flag with download requests. Preserve the original download URL for merged PDFs and keep reporting them as modified after saving.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.30%. Comparing base (68f5e21) to head (6096aae).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22162   +/-   ##
=======================================
  Coverage   90.30%   90.30%           
=======================================
  Files         277      277           
  Lines       67956    67960    +4     
=======================================
+ Hits        61367    61372    +5     
+ Misses       6589     6588    -1     
Flag Coverage Δ
browsertest 66.20% <0.00%> (-0.04%) ⬇️
integrationtest 69.27% <100.00%> (+<0.01%) ⬆️
unittest 60.19% <0.00%> (-0.01%) ⬇️
unittestcli 58.30% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pass an isModified flag with download requests. Preserve the original
download URL for merged PDFs and keep reporting them as modified after
saving.
@calixteman
calixteman force-pushed the firefox-download-is-modified branch from 9128ddf to 6096aae Compare October 12, 2026 17:03
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@timvandermeij timvandermeij changed the title Tell Firefox whether a downloaded PDF has been modified (bug 2076546) Report PDF modifications to Firefox (bug 2076546) Oct 12, 2026
@timvandermeij
timvandermeij merged commit bfcb051 into mozilla:master Oct 12, 2026
22 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for fixing this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants