Skip to content

Fall back after renderer worker failures (PR 21860 follow-up) - #22163

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:renderer-worker-error-fallback
Oct 13, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:renderer-worker-error-fallback

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

The ready handler removed the error listener, leaving requests pending when an uncaught worker error prevented a reply.

Keep error and messageerror listeners until destruction and reject pending requests on failure. Renders fall back during graphics initialization or reject during operator-list execution; later renders use the main thread. Guard FontFallback registration when the renderer has already failed.

@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 82.85714% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.32%. Comparing base (e1412d3) to head (570302d).

Files with missing lines Patch % Lines
src/display/renderer_worker_proxy.js 82.35% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22163      +/-   ##
==========================================
+ Coverage   90.31%   90.32%   +0.01%     
==========================================
  Files         277      277              
  Lines       68004    68030      +26     
==========================================
+ Hits        61418    61451      +33     
+ Misses       6586     6579       -7     
Flag Coverage Δ
browsertest 66.20% <57.14%> (+0.01%) ⬆️
fonttest 8.98% <ø> (ø)
integrationtest 69.36% <68.57%> (+<0.01%) ⬆️
unittest 60.42% <74.28%> (+<0.01%) ⬆️
unittestcli 58.32% <2.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@calixteman
calixteman force-pushed the renderer-worker-error-fallback branch from ba7988d to 7cb8395 Compare October 12, 2026 18:28
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
The ready handler removed the error listener, leaving requests pending
when an uncaught worker error prevented a reply.

Keep error and messageerror listeners until destruction and reject pending
requests on failure. Renders fall back during graphics initialization or
reject during operator-list execution; later renders use the main thread.
Guard FontFallback registration when the renderer has already failed.
@calixteman
calixteman force-pushed the renderer-worker-error-fallback branch from 7cb8395 to 570302d Compare October 12, 2026 19:05
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 570302d (run, references from mozilla/pdf.js.refs@23d8c278ca).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1393 12m 12s 0 0 0 0
Windows ⚠️ 1393 15m 10s 0 1 0 0 view differences

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 13, 2026
@calixteman
calixteman merged commit 6c71c0b into mozilla:master Oct 13, 2026
26 checks passed
@calixteman
calixteman deleted the renderer-worker-error-fallback branch October 13, 2026 11:11
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 13, 2026

This branch was previously deployed

1 inactive deployment
sync_pdfs — 570302d0 Deployed Oct 13, 2026 by Snuffleupagus via request #390
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants