Skip to content

Fix script error reporting - #22166

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:scripting-error-reporting
Oct 13, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:scripting-error-reporting

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Handle thrown null values and failures in string conversion or stack access. Report field errors through the document, since fields without widgets have no send callback.

This prevents error reporting from skipping subsequent actions, field formatting, and OpenAction.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 12, 2026
@github-actions

github-actions Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (756e3cc) to head (1e84678).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22166   +/-   ##
=======================================
  Coverage   90.33%   90.34%           
=======================================
  Files         277      277           
  Lines       68032    68032           
=======================================
+ Hits        61457    61461    +4     
+ Misses       6575     6571    -4     
Flag Coverage Δ
browsertest 66.21% <ø> (-0.01%) ⬇️
fonttest 8.98% <ø> (ø)
integrationtest 69.37% <ø> (+0.01%) ⬆️
unittest 60.43% <ø> (-0.01%) ⬇️
unittestcli 58.35% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, with one question. Thank you.

Comment thread test/unit/scripting_spec.js Resolved
Handle thrown null values and failures in string conversion or stack
access. Report field errors through the document, since fields without
widgets have no send callback.

This prevents error reporting from skipping subsequent actions, field
formatting, and OpenAction.
@calixteman
calixteman force-pushed the scripting-error-reporting branch from fee9d98 to 1e84678 Compare October 13, 2026 18:33
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 13, 2026
@calixteman
calixteman merged commit 288892a into mozilla:master Oct 13, 2026
22 checks passed
@calixteman
calixteman deleted the scripting-error-reporting branch October 13, 2026 18:45
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants