Repository navigation
Fix script error reporting - #22166
Merged
Merged
Conversation
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 12, 2026
Contributor
Viewer preview🗑️ Viewer previews removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22166 +/- ##
=======================================
Coverage 90.33% 90.34%
=======================================
Files 277 277
Lines 68032 68032
=======================================
+ Hits 61457 61461 +4
+ Misses 6575 6571 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Oct 13, 2026
timvandermeij
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, with one question. Thank you.
Handle thrown null values and failures in string conversion or stack access. Report field errors through the document, since fields without widgets have no send callback. This prevents error reporting from skipping subsequent actions, field formatting, and OpenAction.
calixteman
force-pushed
the
scripting-error-reporting
branch
from
October 13, 2026 18:33
fee9d98 to
1e84678
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
timvandermeij
approved these changes
Oct 13, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 13, 2026
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Handle thrown null values and failures in string conversion or stack access. Report field errors through the document, since fields without widgets have no send callback.
This prevents error reporting from skipping subsequent actions, field formatting, and OpenAction.