Skip to content

Improve the performances of the jpx decoder and reduce its size and the jbig2 one - #22175

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:wasm2js_fallbacks
Oct 15, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:wasm2js_fallbacks

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

The fallbacks are now built with wasm2js instead of the deprecated WASM=0 and only contain the converted modules. The compilation of the openjpeg decoder has been improved too.

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for bd5c362 (run, references from mozilla/pdf.js.refs@8acade14e6).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1395 12m 14s 0 1 0 0 view differences
Windows ✅ 1395 14m 34s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 13, 2026
@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.95238% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.40%. Comparing base (43c5e0d) to head (0d5441e).

Files with missing lines Patch % Lines
src/core/wasm_image.js 80.00% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22175      +/-   ##
==========================================
- Coverage   90.40%   90.40%   -0.01%     
==========================================
  Files         277      277              
  Lines       68051    68048       -3     
==========================================
- Hits        61523    61518       -5     
- Misses       6528     6530       +2     
Flag Coverage Δ
browsertest 66.20% <66.66%> (-0.01%) ⬇️
fonttest 8.98% <0.00%> (+<0.01%) ⬆️
integrationtest 69.36% <47.61%> (+<0.01%) ⬆️
unittest 60.58% <52.38%> (-0.01%) ⬇️
unittestcli 58.40% <66.66%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

Comment thread src/core/wasm_image.js Resolved
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 15, 2026
…he jbig2 one

The fallbacks are now built with wasm2js instead of the deprecated WASM=0 and only contain the converted modules.
The compilation of the openjpeg decoder has been improved too.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 15, 2026
@calixteman
calixteman merged commit 9f05dd0 into mozilla:master Oct 15, 2026
22 checks passed
@calixteman
calixteman deleted the wasm2js_fallbacks branch October 15, 2026 12:06
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 15, 2026
@timvandermeij
timvandermeij removed their request for review October 15, 2026 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants