Skip to content

Avoid integer conversion traps in PostScript Wasm - #22191

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:ps-wasm-toint32
Oct 15, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:ps-wasm-toint32

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Match JS x | 0, including for constant-folded cvi.

Match JS `x | 0`, including for constant-folded cvi.
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 9e56fe1 (run, references from mozilla/pdf.js.refs@b3186a726d).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1396 11m 47s 0 0 0 0
Windows ✅ 1396 14m 11s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 14, 2026
@github-actions

github-actions Bot commented Oct 14, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.40%. Comparing base (fcde2e1) to head (9e56fe1).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22191   +/-   ##
=======================================
  Coverage   90.40%   90.40%           
=======================================
  Files         277      277           
  Lines       68051    68064   +13     
=======================================
+ Hits        61520    61535   +15     
+ Misses       6531     6529    -2     
Flag Coverage Δ
browsertest 66.20% <5.55%> (-0.02%) ⬇️
fonttest 8.98% <ø> (ø)
integrationtest 69.35% <5.55%> (-0.01%) ⬇️
unittest 60.59% <100.00%> (+<0.01%) ⬆️
unittestcli 58.39% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 14, 2026
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thanks!

@timvandermeij
timvandermeij merged commit 3da2858 into mozilla:master Oct 15, 2026
30 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 15, 2026

This branch was previously deployed

1 inactive deployment
sync_pdfs — 9e56fe1c Deployed Oct 14, 2026 by calixteman via request #421
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants