Skip to content

Hide the page background behind the main canvas (bug 2070624) - #22196

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:bug2070624-page-bg-gap
Oct 15, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:bug2070624-page-bg-gap

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Make the page background transparent when the main canvas is attached, so it cannot show through at canvas edges. Match role="presentation" to keep the placeholder background when only a detail canvas remains.

Cover rendering, zoom, reset/redraw and detail-only canvases in integration tests.

Make the page background transparent when the main canvas is attached,
so it cannot show through at canvas edges. Match role="presentation" to
keep the placeholder background when only a detail canvas remains.

Cover rendering, zoom, reset/redraw and detail-only canvases in
integration tests.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 15, 2026
@github-actions

github-actions Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 15, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (9f05dd0) to head (3adb659).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22196      +/-   ##
==========================================
- Coverage   90.41%   90.39%   -0.03%     
==========================================
  Files         277      277              
  Lines       68048    68048              
==========================================
- Hits        61526    61511      -15     
- Misses       6522     6537      +15     
Flag Coverage Δ
browsertest 66.19% <ø> (-0.03%) ⬇️
integrationtest 69.35% <ø> (-0.02%) ⬇️
unittest 60.58% <ø> (-0.01%) ⬇️
unittestcli 58.37% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij
timvandermeij merged commit 4e47169 into mozilla:master Oct 15, 2026
22 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thank you for improving this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants