Repository navigation
Hide the page background behind the main canvas (bug 2070624) - #22196
Merged
Merged
Conversation
Make the page background transparent when the main canvas is attached, so it cannot show through at canvas edges. Match role="presentation" to keep the placeholder background when only a detail canvas remains. Cover rendering, zoom, reset/redraw and detail-only canvases in integration tests.
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 15, 2026
Contributor
Viewer preview🗑️ Viewer previews removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22196 +/- ##
==========================================
- Coverage 90.41% 90.39% -0.03%
==========================================
Files 277 277
Lines 68048 68048
==========================================
- Hits 61526 61511 -15
- Misses 6522 6537 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
timvandermeij
approved these changes
Oct 15, 2026
Collaborator
|
Thank you for improving this! |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 15, 2026
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make the page background transparent when the main canvas is attached, so it cannot show through at canvas edges. Match role="presentation" to keep the placeholder background when only a detail canvas remains.
Cover rendering, zoom, reset/redraw and detail-only canvases in integration tests.