Skip to content

Use a DataView when populating the w array in the calculateMD5 function - #22201

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:calculateMD5-DataView
Oct 16, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:calculateMD5-DataView

Conversation

@Snuffleupagus

@Snuffleupagus Snuffleupagus commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

Also, remove redundant & 0xff usage when setting Uint8Array data.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.41%. Comparing base (e3790af) to head (e974401).
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22201      +/-   ##
==========================================
- Coverage   90.41%   90.41%   -0.01%     
==========================================
  Files         277      277              
  Lines       68062    68063       +1     
==========================================
- Hits        61541    61540       -1     
- Misses       6521     6523       +2     
Flag Coverage Δ
browsertest 66.20% <100.00%> (+0.01%) ⬆️
fonttest 8.98% <ø> (ø)
integrationtest 69.35% <100.00%> (-0.01%) ⬇️
unittest 60.61% <100.00%> (+<0.01%) ⬆️
unittestcli 58.39% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 11 untouched benchmarks


Comparing Snuffleupagus:calculateMD5-DataView (e974401) with master (3da2858)1

Open in CodSpeed

Footnotes

  1. No successful run was found on master (dda8b72) during the generation of this report, so 3da2858 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Comment thread src/core/calculate_md5.js Resolved
…function

Also, remove redundant `& 0xff` usage when setting Uint8Array data.
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 16, 2026
@github-actions

github-actions Bot commented Oct 16, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for e974401 (run, references from mozilla/pdf.js.refs@404881ca46).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1396 11m 9s 0 0 0 0
Windows ✅ 1396 18m 6s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 16, 2026
@Snuffleupagus
Snuffleupagus marked this pull request as ready for review October 16, 2026 13:24

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Snuffleupagus merged commit aa1416d into mozilla:master Oct 16, 2026
28 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 16, 2026
@Snuffleupagus
Snuffleupagus deleted the calculateMD5-DataView branch October 16, 2026 14:01

This branch was previously deployed

1 inactive deployment
sync_pdfs — e974401c Deployed Oct 16, 2026 by Snuffleupagus via request #447
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants