Skip to content

Use copyWithin, rather than a manual loop, for non-overlapping data in FlateStream.prototype.#readBlock - #22220

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:FlateStream-readBlock-copyWithin
Oct 17, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:FlateStream-readBlock-copyWithin

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 7899531 (run, references from mozilla/pdf.js.refs@a13e96fb3f).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1398 10m 58s 0 0 0 0
Windows ⚠️ 1398 16m 25s 0 1 0 0 view differences

The report is kept for 30 days and replaced by the next run.

@codecov-commenter

codecov-commenter commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.34%. Comparing base (f73a698) to head (7899531).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22220      +/-   ##
==========================================
- Coverage   90.42%   90.34%   -0.09%     
==========================================
  Files         277      277              
  Lines       68088    68092       +4     
==========================================
- Hits        61567    61516      -51     
- Misses       6521     6576      +55     
Flag Coverage Δ
browsertest 66.39% <100.00%> (-0.01%) ⬇️
fonttest 8.98% <0.00%> (-0.01%) ⬇️
integrationtest 69.18% <100.00%> (-0.13%) ⬇️
unittest 60.65% <100.00%> (+<0.01%) ⬆️
unittestcli 58.45% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 17, 2026
@codspeed

codspeed Bot commented Oct 17, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by ×2.9

⚠️ Different runtime environments detected

Some benchmarks with significant performance changes were compared across different runtime environments,
which may affect the accuracy of the results.

Open the report in CodSpeed to investigate

⚡ 1 improved benchmark
✅ 10 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ FlateStream: inflate 72.9 ms 25.1 ms ×2.9

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Snuffleupagus:FlateStream-readBlock-copyWithin (7899531) with master (f73a698)

Open in CodSpeed

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 17, 2026
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 17, 2026
@calixteman

Copy link
Copy Markdown
Contributor

#22220 (comment)

Nice !

@Snuffleupagus
Snuffleupagus marked this pull request as ready for review October 17, 2026 12:40

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Snuffleupagus merged commit 4fbfbeb into mozilla:master Oct 17, 2026
40 checks passed
@Snuffleupagus
Snuffleupagus deleted the FlateStream-readBlock-copyWithin branch October 17, 2026 14:53
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 17, 2026

This branch was previously deployed

1 inactive deployment
sync_pdfs — 78995310 Deployed Oct 17, 2026 by Snuffleupagus via request #469
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants