Skip to content

Use fill, rather than a manual loop, for repeated data in FlateStream.prototype.#readBlock - #22221

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:FlateStream-readBlock-fill
Oct 17, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:FlateStream-readBlock-fill

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for e6f26e1 (run, references from mozilla/pdf.js.refs@a13e96fb3f).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1398 11m 34s 0 0 0 0
Windows ✅ 1398 14m 11s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

@codecov-commenter

codecov-commenter commented Oct 17, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (f73a698) to head (e6f26e1).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22221      +/-   ##
==========================================
- Coverage   90.42%   90.42%   -0.01%     
==========================================
  Files         277      277              
  Lines       68088    68089       +1     
==========================================
- Hits        61570    61569       -1     
- Misses       6518     6520       +2     
Flag Coverage Δ
browsertest 66.39% <100.00%> (-0.01%) ⬇️
fonttest 8.98% <0.00%> (-0.01%) ⬇️
integrationtest 69.32% <100.00%> (+<0.01%) ⬆️
unittest 60.65% <100.00%> (-0.01%) ⬇️
unittestcli 58.43% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 17, 2026
@github-actions

github-actions Bot commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codspeed

codspeed Bot commented Oct 17, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

ℹ️ 4 benchmarks have no flame graph

The flamegraph could not be generated because too much time was spent in runtime internals, making the visualization not useful for performance analysis.

✅ 11 untouched benchmarks


Comparing Snuffleupagus:FlateStream-readBlock-fill (e6f26e1) with master (f73a698)

Open in CodSpeed

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 17, 2026
@Snuffleupagus
Snuffleupagus marked this pull request as ready for review October 17, 2026 13:40

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Snuffleupagus merged commit b01787f into mozilla:master Oct 17, 2026
32 checks passed
@Snuffleupagus
Snuffleupagus deleted the FlateStream-readBlock-fill branch October 17, 2026 14:55
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 17, 2026

This branch was previously deployed

1 inactive deployment
sync_pdfs — e6f26e11 Deployed Oct 17, 2026 by Snuffleupagus via request #471
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants