Repository navigation
Compile benchmark WebAssembly with TurboFan only - #22228
Conversation
Disable Liftoff in benchmark workers to avoid measuring a mix of baseline and optimized WebAssembly code as background tier-up completes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22228 +/- ##
=======================================
Coverage 90.39% 90.39%
=======================================
Files 277 277
Lines 68162 68162
=======================================
Hits 61615 61615
Misses 6547 6547
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 68.33%
Performance Changes
Tip Curious why performance improved? Comment Comparing |
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good; thank you! (For future reference/readers, this resource helped to get an understanding of how Liftoff and TurboFan relate to each other in WASM compilation: https://www.webassembly-wasm.com/webassembly-core-concepts-browser-runtime/engine-tiering-and-jit-compilation/how-v8-compiles-wasm-with-liftoff-and-turbofan/#two-compilers-with-opposite-goals)
Disable Liftoff in benchmark workers to avoid measuring a mix of baseline and optimized WebAssembly code as background tier-up completes.