Skip to content

Compile benchmark WebAssembly with TurboFan only - #22228

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:benchmarks-no-liftoff
Oct 18, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:benchmarks-no-liftoff

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Disable Liftoff in benchmark workers to avoid measuring a mix of baseline and optimized WebAssembly code as background tier-up completes.

Disable Liftoff in benchmark workers to avoid measuring a mix of baseline
and optimized WebAssembly code as background tier-up completes.
@codecov-commenter

codecov-commenter commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.39%. Comparing base (056904c) to head (832cbbd).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22228   +/-   ##
=======================================
  Coverage   90.39%   90.39%           
=======================================
  Files         277      277           
  Lines       68162    68162           
=======================================
  Hits        61615    61615           
  Misses       6547     6547           
Flag Coverage Δ
unittestcli 58.40% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 18, 2026

Copy link
Copy Markdown

Merging this PR will improve performance by 68.33%

⚡ 4 improved benchmarks
✅ 82 untouched benchmarks

Performance Changes

Benchmark BASE HEAD Efficiency
⚡ JBig2CCITTFaxImage.decode: CCITT (issue5747.pdf) 112.8 ms 36 ms ×3.1
⚡ JBig2CCITTFaxImage.decode: JBIG2 MMR (bitmap-mmr.pdf) 2.1 ms 1.1 ms +91.39%
⚡ JBig2CCITTFaxImage.decode: JBIG2 text region (bitmap-symbol.pdf) 4.7 ms 3.9 ms +21.36%
⚡ JBig2CCITTFaxImage.decode: JBIG2 generic region (bitmap-tpgdon.pdf) 21.8 ms 19.8 ms +10.44%

Tip

Curious why performance improved? Comment @codspeedbot explain why performance improved on this PR, or directly use the CodSpeed MCP with your agent.


Comparing calixteman:benchmarks-no-liftoff (832cbbd) with master (056904c)

Open in CodSpeed

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good; thank you! (For future reference/readers, this resource helped to get an understanding of how Liftoff and TurboFan relate to each other in WASM compilation: https://www.webassembly-wasm.com/webassembly-core-concepts-browser-runtime/engine-tiering-and-jit-compilation/how-v8-compiles-wasm-with-liftoff-and-turbofan/#two-compilers-with-opposite-goals)

@timvandermeij
timvandermeij merged commit 7d9a832 into mozilla:master Oct 18, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants