Skip to content

Don't compress metadata streams when writing - #22234

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:no-compress-metadata-streams
Oct 18, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:no-compress-metadata-streams

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Keep unfiltered, unencrypted XMP scannable (ISO 32000-1, 14.3.2, notes 2 and 3).

Keep unfiltered, unencrypted XMP scannable (ISO 32000-1, 14.3.2,
notes 2 and 3).
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 18, 2026
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.42%. Comparing base (671ac9b) to head (326c015).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22234      +/-   ##
==========================================
- Coverage   90.43%   90.42%   -0.01%     
==========================================
  Files         277      277              
  Lines       68196    68198       +2     
==========================================
- Hits        61674    61671       -3     
- Misses       6522     6527       +5     
Flag Coverage Δ
browsertest 66.33% <ø> (-0.01%) ⬇️
fonttest 8.97% <ø> (ø)
integrationtest 69.26% <ø> (-0.01%) ⬇️
unittest 60.71% <ø> (+<0.01%) ⬆️
unittestcli 58.48% <ø> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@timvandermeij timvandermeij left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing CI; thanks!

@codspeed

codspeed Bot commented Oct 18, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 86 untouched benchmarks


Comparing calixteman:no-compress-metadata-streams (326c015) with master (06c05de)

Open in CodSpeed

@calixteman
calixteman merged commit 4ab316c into mozilla:master Oct 18, 2026
28 checks passed
@calixteman
calixteman deleted the no-compress-metadata-streams branch October 18, 2026 13:23
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants