Skip to content

Tweak the copyWithin threshold in FlateStream.prototype.#readBlock (PR 22220 follow-up) - #22240

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:FlateStream-tweak-copyWithin
Oct 18, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
Snuffleupagus:FlateStream-tweak-copyWithin

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

It just occurred to me that the length being copied needs to be strictly larger than the distance, in order for the data to actually overlap; this patch should improve performance a tiny bit more.

…` (PR 22220 follow-up)

It just occurred to me that the length being copied needs to be *strictly* larger than the distance, in order for the data to actually overlap; this patch should improve performance a tiny bit more.
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for dcba728 (run, references from mozilla/pdf.js.refs@fce2c7a732).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1399 11m 28s 0 0 0 0
Windows ✅ 1399 17m 12s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

@codecov-commenter

codecov-commenter commented Oct 18, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.44%. Comparing base (d14111a) to head (dcba728).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22240   +/-   ##
=======================================
  Coverage   90.43%   90.44%           
=======================================
  Files         277      277           
  Lines       68202    68202           
=======================================
+ Hits        61681    61687    +6     
+ Misses       6521     6515    -6     
Flag Coverage Δ
browsertest 66.34% <100.00%> (+<0.01%) ⬆️
fonttest 8.97% <0.00%> (ø)
integrationtest 69.26% <100.00%> (+<0.01%) ⬆️
unittest 60.75% <100.00%> (+<0.01%) ⬆️
unittestcli 58.50% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 18, 2026
@github-actions

github-actions Bot commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 18, 2026
@codspeed

codspeed Bot commented Oct 18, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 86 untouched benchmarks


Comparing Snuffleupagus:FlateStream-tweak-copyWithin (dcba728) with master (d14111a)

Open in CodSpeed

@Snuffleupagus
Snuffleupagus marked this pull request as ready for review October 18, 2026 15:44
@timvandermeij
timvandermeij merged commit 2a652b6 into mozilla:master Oct 18, 2026
32 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thanks!

This branch was previously deployed

1 inactive deployment
sync_pdfs — dcba7289 Deployed Oct 18, 2026 by Snuffleupagus via request #495
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants