Skip to content

Fall back to the Identity crypt filter without a /CF dictionary - #22249

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix-crypt-filter-without-cf
Oct 22, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix-crypt-filter-without-cf

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

With /V 4 or 5 and no /CF dictionary, or a non-dictionary one, resolving a crypt filter threw a TypeError: the strings and streams of such documents could neither be decrypted nor encrypted when saving. /StmF and /StrF then default to /Identity, which doesn't need a /CF entry.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.45%. Comparing base (9b3e9e4) to head (955e389).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22249      +/-   ##
==========================================
- Coverage   90.46%   90.45%   -0.02%     
==========================================
  Files         277      277              
  Lines       68243    68278      +35     
==========================================
+ Hits        61737    61761      +24     
- Misses       6506     6517      +11     
Flag Coverage Δ
browsertest 66.31% <100.00%> (-0.04%) ⬇️
fonttest 8.97% <ø> (ø)
integrationtest 69.40% <100.00%> (-0.02%) ⬇️
unittest 60.78% <100.00%> (+0.01%) ⬆️
unittestcli 58.51% <100.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 86 untouched benchmarks


Comparing calixteman:fix-crypt-filter-without-cf (955e389) with master (33734f1)

Open in CodSpeed

With /V 4 or 5 and no /CF dictionary, or a non-dictionary one, resolving a
crypt filter threw a TypeError: the strings and streams of such documents
could neither be decrypted nor encrypted when saving. /StmF and /StrF then
default to /Identity, which doesn't need a /CF entry.
@calixteman
calixteman force-pushed the fix-crypt-filter-without-cf branch from b40bb0d to 955e389 Compare October 19, 2026 12:35
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 19, 2026
@timvandermeij
timvandermeij merged commit 68ed4a6 into mozilla:master Oct 22, 2026
23 of 24 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants