Skip to content

Use TypedArray.prototype.set in the meshPackData function - #22250

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:meshPackData-TypedArray-set
Oct 21, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:meshPackData-TypedArray-set

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

Rather than manually getting and setting each coordinate respectively color component, we can simply utilize TypedArray.prototype.set instead.

@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 18c31b1 (run, references from mozilla/pdf.js.refs@b283667883).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1405 13m 45s 0 0 0 0
Windows ✅ 1405 16m 45s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 19, 2026
@github-actions

github-actions Bot commented Oct 19, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 19, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (439f5ee) to head (18c31b1).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22250   +/-   ##
=======================================
  Coverage   90.46%   90.47%           
=======================================
  Files         277      277           
  Lines       68280    68274    -6     
=======================================
- Hits        61772    61768    -4     
+ Misses       6508     6506    -2     
Flag Coverage Δ
browsertest 66.32% <100.00%> (-0.01%) ⬇️
fonttest 8.98% <ø> (ø)
integrationtest 69.46% <0.00%> (+0.01%) ⬆️
unittest 60.86% <0.00%> (+0.01%) ⬆️
unittestcli 58.61% <0.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 19, 2026
@codspeed

codspeed Bot commented Oct 19, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

1 note

ℹ️ This run is excluded from the branch history

This commit was force-pushed, so this run no longer appears in the branch's performance history.

✅ 86 untouched benchmarks


Comparing Snuffleupagus:meshPackData-TypedArray-set (6863cf6) with master (439f5ee)

Open in CodSpeed

@Snuffleupagus
Snuffleupagus marked this pull request as ready for review October 19, 2026 12:20
Comment thread src/core/pattern.js Resolved
@Snuffleupagus
Snuffleupagus force-pushed the meshPackData-TypedArray-set branch from 1a77f1b to 6863cf6 Compare October 21, 2026 15:57
Rather than manually getting and setting each coordinate respectively color component, we can simply utilize `TypedArray.prototype.set` instead.
@Snuffleupagus
Snuffleupagus force-pushed the meshPackData-TypedArray-set branch from 6863cf6 to 18c31b1 Compare October 21, 2026 15:59
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@Snuffleupagus
Snuffleupagus merged commit d2f4327 into mozilla:master Oct 21, 2026
28 checks passed
@Snuffleupagus
Snuffleupagus deleted the meshPackData-TypedArray-set branch October 21, 2026 16:37
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026

This branch was previously deployed

1 inactive deployment
sync_pdfs — 18c31b1c Deployed Oct 21, 2026 by Snuffleupagus via request #542
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants