Repository navigation
Bound format 12 cmap expansion - #22255
Merged
Merged
Conversation
Contributor
Reference testsResults for b2bb72a (run, references from mozilla/pdf.js.refs@1d2edf901a).
The report is kept for 30 days and replaced by the next run. |
Contributor
Viewer preview🗑️ Viewer previews removed. |
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 19, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22255 +/- ##
=======================================
Coverage 90.45% 90.46%
=======================================
Files 277 277
Lines 68274 68277 +3
=======================================
+ Hits 61757 61765 +8
+ Misses 6517 6512 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 19, 2026
calixteman
force-pushed
the
fix-cmap-format12
branch
from
October 21, 2026 11:42
b2bb72a to
a5ddac4
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 21, 2026
Malformed cmap groups can expand into billions of mappings; oversized group counts can keep the parser reading past EOF. Bound group counts by the declared length and remaining stream bytes. Restrict ranges to valid glyph IDs and Unicode code points, and stop reading groups after the mapping count exceeds 0x110000. Add tests for oversized ranges, forged lengths/counts, overlapping groups, and valid mappings, plus a regression PDF.
calixteman
force-pushed
the
fix-cmap-format12
branch
from
October 21, 2026 12:14
a5ddac4 to
c725c6e
Compare
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 21, 2026
sync-pdfs-for-pdf-js Bot
pushed a commit
to mozilla/pdf.js.refs
that referenced
this pull request
Oct 21, 2026
timvandermeij
removed their request for review
October 22, 2026 19:09
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Malformed cmap groups can expand into billions of mappings; oversized group counts can keep the parser reading past EOF.
Bound group counts by the declared length and remaining stream bytes. Restrict ranges to valid glyph IDs and Unicode code points, and stop reading groups after the mapping count exceeds 0x110000.
Add tests for oversized ranges, forged lengths/counts, overlapping groups, and valid mappings, plus a regression PDF.