Skip to content

Speed up asyncGetBytesFromDecompressionStream - #22276

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:decompression-stream-read-loop
Oct 21, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:decompression-stream-read-loop

Conversation

@calixteman

@calixteman calixteman commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Read decompressed chunks with reader.read() rather than for await, skip writer.ready waits, and return single-chunk output without copying it.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for b574c23 (run, references from mozilla/pdf.js.refs@7145488b43).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1399 13m 25s 0 0 0 0
Windows ✅ 1399 15m 31s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

@github-actions

github-actions Bot commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 20, 2026
@codecov-commenter

codecov-commenter commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.47%. Comparing base (9b35eb8) to head (6304478).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22276      +/-   ##
==========================================
+ Coverage   90.45%   90.47%   +0.01%     
==========================================
  Files         277      277              
  Lines       68274    68280       +6     
==========================================
+ Hits        61757    61773      +16     
+ Misses       6517     6507      -10     
Flag Coverage Δ
browsertest 66.35% <100.00%> (+0.03%) ⬆️
fonttest 8.98% <0.00%> (-0.01%) ⬇️
integrationtest 69.44% <100.00%> (+<0.01%) ⬆️
unittest 60.83% <100.00%> (+0.02%) ⬆️
unittestcli 58.57% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 20, 2026
Comment thread src/core/decode_stream.js Resolved
@codspeed

codspeed Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 86 untouched benchmarks


Comparing calixteman:decompression-stream-read-loop (6304478) with master (875f569)

Open in CodSpeed

Comment thread src/core/decode_stream.js Resolved
Comment thread src/core/decode_stream.js Resolved
@calixteman
calixteman force-pushed the decompression-stream-read-loop branch from b574c23 to 9b78635 Compare October 21, 2026 12:23
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@calixteman
calixteman force-pushed the decompression-stream-read-loop branch from 9b78635 to 2b1ed71 Compare October 21, 2026 12:39
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
Comment thread src/core/decode_stream.js Resolved
Comment thread test/unit/stream_spec.js Resolved
@calixteman
calixteman force-pushed the decompression-stream-read-loop branch from 2b1ed71 to af65559 Compare October 21, 2026 13:03
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
Read decompressed chunks with reader.read() rather than `for await`, skip
writer.ready waits, and return single-chunk output without copying it.
@calixteman
calixteman force-pushed the decompression-stream-read-loop branch from af65559 to 6304478 Compare October 21, 2026 13:12
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@calixteman
calixteman merged commit 03c06f7 into mozilla:master Oct 21, 2026
24 checks passed
@calixteman
calixteman deleted the decompression-stream-read-loop branch October 21, 2026 13:56
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@timvandermeij
timvandermeij removed their request for review October 22, 2026 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants