Skip to content

Reset the alpha of colored Type3 glyphs in the glyph's graphics state - #22282

Merged
calixteman merged 1 commit into
mozilla:masterfrom
calixteman:type3_d0_alpha
Oct 21, 2026
Merged

calixteman merged 1 commit into
mozilla:masterfrom
calixteman:type3_d0_alpha

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for b29e70e (run, references from mozilla/pdf.js.refs@7145488b43).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1400 12m 3s 0 0 0 1
Windows ⚠️ 1400 15m 47s 0 1 0 1 view differences

The report is kept for 30 days and replaced by the next run.

@codecov-commenter

codecov-commenter commented Oct 21, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.43%. Comparing base (a0c1035) to head (b29e70e).
⚠️ Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22282      +/-   ##
==========================================
- Coverage   90.45%   90.43%   -0.03%     
==========================================
  Files         277      277              
  Lines       68282    68259      -23     
==========================================
- Hits        61764    61729      -35     
- Misses       6518     6530      +12     
Flag Coverage Δ
browsertest 66.31% <100.00%> (-0.01%) ⬇️
fonttest 8.99% <ø> (+0.01%) ⬆️
integrationtest 69.40% <0.00%> (-0.01%) ⬇️
unittest 60.79% <100.00%> (+0.02%) ⬆️
unittestcli 58.52% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@github-actions

github-actions Bot commented Oct 21, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

However, a slightly orthogonal question: Would it make sense, in a follow-up, to instead insert the needed operators directly in the Type3-opList in the worker-thread?

pdf.js/src/core/evaluator.js

Lines 4979 to 4983 in fb03adb

case OPS.setCharWidth:
if (!fontBBoxSize) {
this.#guessType3FontBBox(operatorList);
}
break;

@calixteman
calixteman merged commit 2f75449 into mozilla:master Oct 21, 2026
31 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 21, 2026
@codspeed

codspeed Bot commented Oct 21, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 86 untouched benchmarks


Comparing calixteman:type3_d0_alpha (b29e70e) with master (fb03adb)

Open in CodSpeed

This branch was previously deployed

1 inactive deployment
sync_pdfs — b29e70ed Deployed Oct 21, 2026 by calixteman via request #531
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants