Repository navigation
Use the Util.pointBoundingBox helper in the meshUpdateBounds function - #22299
Snuffleupagus merged 1 commit into
Conversation
Reference testsResults for f9ff3e0 (run, references from mozilla/pdf.js.refs@a5ca8637a7).
The report is kept for 30 days and replaced by the next run. |
Viewer preview🗑️ Viewer previews removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22299 +/- ##
=======================================
Coverage 90.56% 90.57%
=======================================
Files 278 278
Lines 68508 68501 -7
=======================================
- Hits 62046 62045 -1
+ Misses 6462 6456 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 14.93%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
|
It's not obvious, at least to me, that the performance regression is "real"; considering that:
|
|
@calixteman we might want to use the same runner all the time |
Normally it should be addressed by #22302. Can you rebase ? |
2fbd214 to
9ca61ce
Compare
Done; but it seems that benchmarking doesn't start now, note https://github.com/mozilla/pdf.js/pull/22299/checks?check_run_id=119911302445 |
timvandermeij
left a comment
There was a problem hiding this comment.
r=me; thank you for simplifying this!
|
@Snuffleupagus can you rebase ? |
9ca61ce to
f9ff3e0
Compare
f9ff3e0 to
8bebac8
Compare
8bebac8 to
676b5a0
Compare
676b5a0 to
d649d1a
Compare
|
This might be slightly slower, but given how noisy the benchmark results have gotten (with completely unrelated regressions/improvements) it's somewhat difficult to know what to make of it. |
d649d1a to
e59216b
Compare
e59216b to
6a2fc77
Compare
6a2fc77 to
b69e10f
Compare
b69e10f to
b562f11
Compare
No description provided.