Skip to content

Use the Util.pointBoundingBox helper in the meshUpdateBounds function - #22299

Merged
Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:meshUpdateBounds-pointBoundingBox
Oct 26, 2026
Merged

Snuffleupagus merged 1 commit into
mozilla:masterfrom
Snuffleupagus:meshUpdateBounds-pointBoundingBox

Conversation

@Snuffleupagus

Copy link
Copy Markdown
Collaborator

No description provided.

@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for f9ff3e0 (run, references from mozilla/pdf.js.refs@a5ca8637a7).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ✅ 1406 12m 43s 0 0 0 0
Windows ✅ 1406 16m 33s 0 0 0 0

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 22, 2026
@github-actions

github-actions Bot commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

@codecov-commenter

codecov-commenter commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.57%. Comparing base (e4e2911) to head (b562f11).

Additional details and impacted files
@@           Coverage Diff           @@
##           master   #22299   +/-   ##
=======================================
  Coverage   90.56%   90.57%           
=======================================
  Files         278      278           
  Lines       68508    68501    -7     
=======================================
- Hits        62046    62045    -1     
+ Misses       6462     6456    -6     
Flag Coverage Δ
browsertest 66.26% <100.00%> (+<0.01%) ⬆️
fonttest 8.99% <ø> (ø)
integrationtest 69.51% <0.00%> (+0.01%) ⬆️
unittest 61.29% <0.00%> (+0.01%) ⬆️
unittestcli 59.03% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 22, 2026
@codspeed

codspeed Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 14.93%

❌ 4 regressed benchmarks
✅ 84 untouched benchmarks
⏩ 174 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ Pattern.parseShading: tensor-product patch mesh (personwithdog.pdf) 30.4 ms 38.8 ms -21.61%
❌ PartialEvaluator.buildPath: lines (bug1743245.pdf) 16.3 ms 19.1 ms -14.65%
❌ EvaluatorPreprocessor.read: paths (bug1743245.pdf) 57.2 ms 65 ms -12.08%
❌ Pattern.parseShading: Coons patch mesh (coons-allflags-withfunction.pdf) 411.9 µs 462.7 µs -10.97%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing Snuffleupagus:meshUpdateBounds-pointBoundingBox (b562f11) with master (e4e2911)

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

It's not obvious, at least to me, that the performance regression is "real"; considering that:

  • It's comparing totally different CPUs, INTEL(R) XEON(R) PLATINUM 8573C vs AMD EPYC 7763 64-Core Processor.
  • The, for this PR, unrelated PartialEvaluator.buildPath: lines (bug1743245.pdf) test-case shows a regression in the Util.pointBoundingBox method.

@marco-c

marco-c commented Oct 22, 2026

Copy link
Copy Markdown
Contributor

@calixteman we might want to use the same runner all the time

@calixteman

Copy link
Copy Markdown
Contributor

It's not obvious, at least to me, that the performance regression is "real"; considering that:

* It's comparing totally different CPUs, `INTEL(R) XEON(R) PLATINUM 8573C` vs `AMD EPYC 7763 64-Core Processor`.

* The, for this PR, unrelated `PartialEvaluator.buildPath: lines (bug1743245.pdf)` test-case shows a regression in the `Util.pointBoundingBox` method.

Normally it should be addressed by #22302.

Can you rebase ?

@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from 2fbd214 to 9ca61ce Compare October 22, 2026 15:19
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 22, 2026
@Snuffleupagus

Snuffleupagus commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator Author

Can you rebase ?

Done; but it seems that benchmarking doesn't start now, note https://github.com/mozilla/pdf.js/pull/22299/checks?check_run_id=119911302445

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me; thank you for simplifying this!

@calixteman

Copy link
Copy Markdown
Contributor

@Snuffleupagus can you rebase ?

@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from 9ca61ce to f9ff3e0 Compare October 23, 2026 10:04
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 23, 2026
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 23, 2026
@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from f9ff3e0 to 8bebac8 Compare October 23, 2026 10:52
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 23, 2026
@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from 8bebac8 to 676b5a0 Compare October 23, 2026 14:48
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 23, 2026
@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from 676b5a0 to d649d1a Compare October 23, 2026 15:00
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 23, 2026
@Snuffleupagus

Copy link
Copy Markdown
Collaborator Author

This might be slightly slower, but given how noisy the benchmark results have gotten (with completely unrelated regressions/improvements) it's somewhat difficult to know what to make of it.

@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from d649d1a to e59216b Compare October 23, 2026 18:39
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 23, 2026
@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from e59216b to 6a2fc77 Compare October 24, 2026 11:02
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 24, 2026
@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from 6a2fc77 to b69e10f Compare October 25, 2026 20:13
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 25, 2026
@Snuffleupagus
Snuffleupagus force-pushed the meshUpdateBounds-pointBoundingBox branch from b69e10f to b562f11 Compare October 26, 2026 12:18
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 26, 2026

@calixteman calixteman left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Snuffleupagus merged commit f99d131 into mozilla:master Oct 26, 2026
23 of 24 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 26, 2026
@Snuffleupagus
Snuffleupagus deleted the meshUpdateBounds-pointBoundingBox branch October 26, 2026 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants