Repository navigation
Keep fullscreen inside the browser window in the Firefox integration tests - #22318
Merged
calixteman merged 1 commit intoOct 23, 2026
Merged
Conversation
…tests Since bug 2078254, Firefox on Linux denies fullscreen requests when the window can't be made fullscreen, which is the case under Xvfb since there's no window manager. The presentation mode integration tests were failing because of that.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22318 +/- ##
==========================================
- Coverage 90.47% 90.46% -0.01%
==========================================
Files 277 277
Lines 68313 68313
==========================================
- Hits 61803 61799 -4
- Misses 6510 6514 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Snuffleupagus
approved these changes
Oct 23, 2026
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since bug 2078254, Firefox on Linux denies fullscreen requests when the window can't be made fullscreen, which is the case under Xvfb since there's no window manager. The presentation mode integration tests were failing because of that.