Repository navigation
Use fixed V8 hash and random seeds in the benchmarks - #22323
Conversation
The walltime results vary between runs of the same code by up to ~10% for some benchmarks, while being stable within a run. Fixing the seeds roughly halved the number of benchmarks differing by more than 5% between runs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22323 +/- ##
=======================================
Coverage 90.47% 90.47%
=======================================
Files 277 277
Lines 68313 68400 +87
=======================================
+ Hits 61803 61882 +79
- Misses 6510 6518 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will degrade performance by 1.44%
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
The walltime results vary between runs of the same code by up to ~10% for some benchmarks, while being stable within a run. Fixing the seeds roughly halved the number of benchmarks differing by more than 5% between runs.