Repository navigation
Update getTextContent to use getReader instead - #22329
Conversation
Given that PR 22276 just replaced a `for await` loop, since a `while` loop over `getReader` invocations is apparently faster, let's do the same thing in the `getTextContent` method.
Reference testsResults for f913cc0 (run, references from mozilla/pdf.js.refs@b5c54fdd60).
The report is kept for 30 days and replaced by the next run. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22329 +/- ##
==========================================
- Coverage 90.50% 90.42% -0.09%
==========================================
Files 277 277
Lines 68401 68405 +4
==========================================
- Hits 61908 61852 -56
- Misses 6493 6553 +60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Viewer preview🗑️ Viewer previews removed. |
Merging this PR will regress 2 benchmarks
Warning Please fix the performance issues or acknowledge them on CodSpeed. Performance Changes
Tip Investigate this regression by commenting Comparing Footnotes
|
timvandermeij
left a comment
There was a problem hiding this comment.
Looks good to me, with passing CI. Thanks!
Given that PR 22276 just replaced a
for awaitloop, since awhileloop overgetReaderinvocations is apparently faster, let's do the same thing in thegetTextContentmethod.