Skip to content

Align tiling patterns on rotated fallback glyphs - #22343

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix-rotated-glyph-pattern
Oct 27, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix-rotated-glyph-pattern

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Compensate for glyph rotation even when no width scaling is needed.

Compensate for glyph rotation even when no width scaling is needed.
@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 26, 2026
@codecov-commenter

codecov-commenter commented Oct 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.48%. Comparing base (0e7e4bb) to head (9eb1b54).

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22343      +/-   ##
==========================================
- Coverage   90.56%   90.48%   -0.08%     
==========================================
  Files         278      278              
  Lines       68508    68509       +1     
==========================================
- Hits        62044    61992      -52     
- Misses       6464     6517      +53     
Flag Coverage Δ
browsertest 66.26% <100.00%> (+0.02%) ⬆️
fonttest 8.99% <ø> (ø)
unittest 61.29% <33.33%> (-0.01%) ⬇️
unittestcli 59.03% <33.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 27, 2026

Copy link
Copy Markdown

Merging this PR will degrade performance by 9.2%

⚡ 1 improved benchmark
❌ 3 regressed benchmarks
✅ 84 untouched benchmarks
⏩ 174 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ Pattern.parseShading: tensor-product patch mesh (personwithdog.pdf) 30.4 ms 37.2 ms -18.19%
❌ Lexer.getObj: paths (bug1743245.pdf) 24 ms 28.7 ms -16.51%
❌ Pattern.parseShading: Coons patch mesh (coons-allflags-withfunction.pdf) 411.9 µs 463 µs -11.03%
⚡ PDFPageProxy.render: luminosity soft mask (issue18956.pdf) 22.7 ms 20.2 ms +11.87%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing calixteman:fix-rotated-glyph-pattern (9eb1b54) with master (e4e2911)2

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

  2. No successful run was found on master (0e7e4bb) during the generation of this report, so e4e2911 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@timvandermeij
timvandermeij merged commit 2d68656 into mozilla:master Oct 27, 2026
27 of 28 checks passed
@timvandermeij

Copy link
Copy Markdown
Collaborator

Looks good; thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants