Skip to content

Only wait for WebGPU after receiving mesh patterns (bug 2086057) - #22358

Merged
timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/bug-2086057-renderer-gpu-wait
Oct 27, 2026
Merged

timvandermeij merged 1 commit into
mozilla:masterfrom
calixteman:fix/bug-2086057-renderer-gpu-wait

Conversation

@calixteman

Copy link
Copy Markdown
Contributor

Avoid blocking graphics initialization on WebGPU. Wait before executing operators once a mesh pattern has arrived, including Type 3 patterns.

@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Viewer preview

🗑️ Viewer previews removed.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 27, 2026
@codecov-commenter

codecov-commenter commented Oct 27, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 64.28571% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.58%. Comparing base (8e62d24) to head (4446c1c).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/display/renderer_worker.js 64.28% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #22358      +/-   ##
==========================================
- Coverage   90.59%   90.58%   -0.01%     
==========================================
  Files         278      278              
  Lines       68535    68544       +9     
==========================================
+ Hits        62088    62090       +2     
- Misses       6447     6454       +7     
Flag Coverage Δ
browsertest 66.22% <64.28%> (-0.02%) ⬇️
fonttest 8.99% <ø> (-0.01%) ⬇️
integrationtest 69.54% <50.00%> (-0.01%) ⬇️
unittest 61.26% <50.00%> (-0.01%) ⬇️
unittestcli 59.00% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@codspeed

codspeed Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Merging this PR will degrade performance by 17.17%

❌ 1 regressed benchmark
✅ 87 untouched benchmarks
⏩ 174 skipped benchmarks1

Warning

Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

Benchmark BASE HEAD Efficiency
❌ PartialEvaluator.buildPath: lines (bug1743245.pdf) 15.7 ms 19 ms -17.17%

Tip

Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.


Comparing calixteman:fix/bug-2086057-renderer-gpu-wait (4446c1c) with master (2a1b241)

Open in CodSpeed

Footnotes

  1. 174 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

Comment thread src/display/renderer_worker.js Resolved
Avoid blocking graphics initialization on WebGPU. Wait before executing
operators once a mesh pattern has arrived, including Type 3 patterns.
@github-actions

github-actions Bot commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

Reference tests

Results for 4446c1c (run, references from mozilla/pdf.js.refs@8e356ae2f2).

Platform Status Tests Total runtime Errors Different FBF No reference Report
Linux ⚠️ 1411 13m 55s 0 1 0 0 view differences
Windows ⚠️ 1411 15m 37s 0 1 0 0 view differences

The report is kept for 30 days and replaced by the next run.

sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 27, 2026

@timvandermeij timvandermeij left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me like this; thanks!

@Snuffleupagus Snuffleupagus left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thanks.

@timvandermeij
timvandermeij merged commit 279175b into mozilla:master Oct 27, 2026
35 of 36 checks passed
sync-pdfs-for-pdf-js Bot pushed a commit to mozilla/pdf.js.refs that referenced this pull request Oct 27, 2026
@calixteman
calixteman deleted the fix/bug-2086057-renderer-gpu-wait branch October 28, 2026 09:08

This branch was previously deployed

1 inactive deployment
sync_pdfs — 4446c1cb Deployed Oct 27, 2026 by Snuffleupagus via request #638
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants