Repository navigation
Move OutputScale to its own file, and always provide the pixelRatio to the CanvasGraphics class - #22561
Conversation
Reference testsResults for c55722d (run, references from mozilla/pdf.js.refs@b8f2971334).
The report is kept for 30 days and replaced by the next run. |
Viewer preview🗑️ Viewer previews removed. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #22561 +/- ##
==========================================
- Coverage 90.87% 90.87% -0.01%
==========================================
Files 279 280 +1
Lines 69842 69840 -2
==========================================
- Hits 63472 63465 -7
- Misses 6370 6375 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merging this PR will improve performance by 11.81%
Performance Changes
Tip Curious why performance improved? Comment Comparing Footnotes
|
…o` to the `CanvasGraphics` class This way we avoid having to bundle the `OutputScale` class in the renderer-worker, since it cannot meaningfully be used there anyway (note PR 22120). *Note:* This reduces the size of the `gulp mozcentral` bundle by `476` bytes, which isn't a lot but still cannot hurt.
c55722d to
9271d50
Compare
|
Looks good; thank you! |
This way we avoid having to bundle the
OutputScaleclass in the renderer-worker, since it cannot meaningfully be used there anyway (note PR #22120).Note: This reduces the size of the
gulp mozcentralbundle by476bytes, which isn't a lot but still cannot hurt.