Repository navigation
docs: use :root to override the default fonts in the v5 custom fonts guide - #93
Open
jeltehomminga wants to merge 1 commit into
Open
jeltehomminga wants to merge 1 commit into
jeltehomminga wants to merge 1 commit into
Conversation
|
@jeltehomminga is attempting to deploy a commit to the nativewind Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
🟢 Approval recommended
The focused documentation change reflects the reported native-platform workaround, with no identified blocking issues.
No open issues 🎉
What changed in this PR
Updates the v5 custom fonts guide to document a working override for default fonts on iOS and Android in the current release candidate.
Changes:
- Replaces
@themewith a:rootblock and instructs readers to place it after imports. - Explains why Nativewind’s platform defaults prevent the
@themeoverride from taking effect.
| File | Description |
|---|---|
content/v5/guides/custom-fonts.mdx |
Updates the default-font override example and explains the release-candidate limitation. |
Review effort: Balanced
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The custom fonts guide overrides the default font with
@theme { --font-sans: ... }, but in 5.0.0-rc.0 that has no effect on iOS and Android, see nativewind/nativewind#1876. A:rootblock after the imports works on both, so this switches the example to that and adds one line on why.Checked with Courier in the repro from that issue, on an iOS 26.5 simulator and an Android 17 emulator:
font-sansresolves toCourierwith:root, and toSystem/SystemAndroidwith@theme. I didn't check web.If the issue gets a code fix, this is easy to revert, or I can drop the last sentence.
pnpm test:llmandpnpm buildpass.