Repository navigation
aclk: restore the t-rx timestamp in HTTP replies - #24252
Conversation
netdata#18218 dropped the assignment of query->created when it removed _aclk_queue_query(), so every reply has sent t-rx: 0 since. Stamp it in aclk_query_new() next to created_tv.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to Cloud query replies should include the restored receipt timestamp. The supplied change context indicates no actionable risk requiring a pre-merge fix. Pre-merge checks |
|
|
thiagoftsm
left a comment
There was a problem hiding this comment.
Cloud is working as expected. LGTM!
netdata#18218 dropped the assignment of query->created when it removed _aclk_queue_query(), so every reply has sent t-rx: 0 since. Stamp it in aclk_query_new() next to created_tv. (cherry picked from commit 3ba16bb)



#18218 removed
_aclk_queue_query(), which set bothquery->created_tvandquery->created, but moved onlycreated_tvintoaclk_query_new().createdis serialized ast-rxin every HTTP reply to Cloud, so it has been0since then.This stamps
createdwithnow_realtime_usec()inaclk_query_new(), as before.Tested on a live agent with a fake-Cloud harness that injects HTTP
cmdmessages through the real receive path and captures the reply headers (30 queries per build, success and invalid-request replies): master sendst-rx: 0in every reply; with the fixt-rxis the receipt wall time, 3–37 ms after injection and under 1 ms before the reply.Summary by CodeRabbit