Skip to content

fix(deck): fix route 405 on attachment deletion and null-check crashe… - #8682

Open
aquananu wants to merge 1 commit into
nextcloud:stable34from
aquananu:fix/safe-attachment-guards-stable34
Open

aquananu wants to merge 1 commit into
nextcloud:stable34from
aquananu:fix/safe-attachment-guards-stable34

Conversation

@aquananu

@aquananu aquananu commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

…s in sidebar and attachment list

  • appinfo/routes.php: register attachment_ocs#delete before update and add regex requirements to prevent 405 Method Not Allowed
  • src/components/card/AttachmentList.vue: optional chaining on attachment.extendedData.info.filename
  • src/components/card/CardSidebar.vue: add null checks for newCard/oldCard in currentCard watcher
  • src/components/card/Description.vue: safe tiptap editor teardown
  • src/store/attachment.js: properly splice unshared attachments from state
  • Resolves: #
  • Target version: main

Summary

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

🤖 AI (if applicable)

  • The content of this PR was partly or fully generated using AI (N/A)

…s in sidebar and attachment list

- appinfo/routes.php: register attachment_ocs#delete before update and add regex requirements to prevent 405 Method Not Allowed
- src/components/card/AttachmentList.vue: optional chaining on attachment.extendedData.info.filename
- src/components/card/CardSidebar.vue: add null checks for newCard/oldCard in currentCard watcher
- src/components/card/Description.vue: safe tiptap editor teardown
- src/store/attachment.js: properly splice unshared attachments from state

Signed-off-by: aquananu <AQUANANU@GMAIL.COM>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant