Repository navigation
Add support for redis user enviroment variable - #892
jholmes802 wants to merge 2 commits into
Conversation
| @@ -212,14 +212,18 @@ Redis env vars | |||
| value: {{ .Values.externalRedis.password | quote }} | |||
| {{- end }} | |||
| {{- end }}{{/* end-of redis-enabled*/}} | |||
There was a problem hiding this comment.
@wrenix I am not seeing an issues with the end. Are you suggesting this should be in the redis.auth.enabled section with the rest of those settings?
| | `nextcloud.mail.smtp.port` | Optional SMTP port | `nil` | | ||
| | `nextcloud.mail.smtp.authtype` | SMTP authentication method | `LOGIN` | | ||
| | `nextcloud.mail.smtp.name` | SMTP username, ONLY the part before the domain name. i.e. 'postmaster' NOT 'postmaster@example.com' | `''` | | ||
| | `nextcloud.mail.smtp.name` | SMTP username, ONLY the part before the domain name. i.e. 'postmaster' NOT '<postmaster@example.com>' | `''` | |
There was a problem hiding this comment.
My bad, I was moving quickly and didn't notice it get caught in my auto formater. Sorry about that. Undoing as I speak
| auth: | ||
| enabled: true | ||
| # Username for redis authentication | ||
| # user: "default" |
There was a problem hiding this comment.
please do not comment value-fields out ... make them nil instatt.
| # user: "default" | |
| user: |
eb9d567 to
604ba8b
Compare
| value: {{ .Values.externalRedis.password | quote }} | ||
| {{- end }} | ||
| {{- end }}{{/* end-of redis-enabled*/}} | ||
| {{- if .Values.redis.auth.user }} |
There was a problem hiding this comment.
| {{- if .Values.redis.auth.user }} | |
| {{- with .Values.redis.auth.user }} | |
| .... | |
| value: {{ quote . }} |
There was a problem hiding this comment.
I am confused why should I use with, seems like that would set it as a variable for the block? Or am I interpreting that wrong.
There was a problem hiding this comment.
@wrenix can you provide some clarification on this? I believe all the updates you requested besides this have been made.
Description of the change
This change adds a native value spec for the username a redis account may need.
Currently the only way to do this is with an "extraEnv" section, but it doesn't update the REDIS_URL environment variable.
This change focuses on adding an example to the values.yaml doc, and the helpers which generates the environment variables.
Benefits
Adds native support for a redis user other than the default.
Possible drawbacks
Can't think of any at the time.
Applicable issues
Additional information
Checklist
Chart.yamlaccording to semver.