Repository navigation
Bump foldseek/createdb and foldseek/easysearch to 10.941cd33 - #13027
Conversation
- Update conda env and biocontainers to foldseek 10.941cd33 - easysearch: discover the main DB basename via its .lookup file instead of misusing ext.prefix2/meta2.id - Add maintainers and .m8 EDAM ontology to meta.yml - Fix stub test name and regenerate snapshots Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
erikrikarddaniel
left a comment
There was a problem hiding this comment.
Interesting version numbering scheme.
| prefix = task.ext.prefix ?: "${meta.id}" | ||
| prefix2 = task.ext.prefix2 ?: "${meta2.id}" | ||
| """ | ||
| DB_NAME=\$(find -L "${db}/" -maxdepth 1 -name '*.lookup' | sed 's/\\.lookup\$//') |
There was a problem hiding this comment.
Nothing guarantees exactly one .lookup match. With multiple DBs in the directory, extra paths become extra positional args (shifting output/tmp); with none (e.g. --write-lookup 0), DB_NAME is empty and the query is used as the target DB. Suggest failing fast, and quoting "\$DB_NAME" on line 29:
| DB_NAME=\$(find -L "${db}/" -maxdepth 1 -name '*.lookup' | sed 's/\\.lookup\$//') | |
| DB_NAME=\$(find -L "${db}/" -maxdepth 1 -name '*.lookup' | sed 's/\\.lookup\$//') | |
| if [ "\$(printf '%s\\n' "\$DB_NAME" | grep -c .)" -ne 1 ]; then | |
| echo "ERROR: expected exactly one .lookup file in ${db}" >&2 | |
| exit 1 | |
| fi |
Comment added by Claude Opus 5.5
There was a problem hiding this comment.
reverted in using meta2.id, not prefix2 as AGENTS.md says:
- `ext.prefix2`: a second prefix used in case of multiple outputs; you **MUST NOT** use it for other purposes, e.g. file formats
and .lookup as a fallback option - but only if only 1 is there, else stops with error
There was a problem hiding this comment.
Thanks, confirmed in 8147a87: the .lookup fallback now fails fast unless exactly one match is found, and "$DB_NAME" is quoted. The new "lookup fallback" test covers the discovery path. Optional: a test for the zero/multiple .lookup error case.
Comment added by Claude Opus 5.5
| @@ -21,14 +21,15 @@ process FOLDSEEK_EASYSEARCH { | |||
| script: | |||
| def args = task.ext.args ?: '' | |||
| prefix = task.ext.prefix ?: "${meta.id}" | |||
There was a problem hiding this comment.
Dropping prefix2 is a breaking change: pipelines can no longer select which DB in the directory to search. Suggest keeping it as an override and only falling back to .lookup discovery when unset, e.g. def db_name = task.ext.prefix2 ? "${db}/${task.ext.prefix2}" : '' then DB_NAME=${db_name ?: '$(find ...)'}. Otherwise, please flag the change in the PR description. meta2 is now unused apart from docs.
Comment added by Claude Opus 5.5
There was a problem hiding this comment.
The module uses ${db}/${meta2.id} when that database exists, otherwise it falls back to the .lookup search. ext.prefix2 stays unused, as AGENTS.md requires. This restores the old default, since meta2.id was what it used before. Pipelines can pick one database in a folder with several by setting meta2.id instead of ext.prefix2.
There was a problem hiding this comment.
Agreed, my ext.prefix2 suggestion was wrong given AGENTS.md. Using meta2.id first with the .lookup fallback restores the previous default and keeps meta2 meaningful. Looks good.
Comment added by Claude Opus 5.5
…back
Use ${db}/${meta2.id} when it exists so pipelines can still pick a
database in a multi-DB directory; otherwise fall back to the single
.lookup file and exit with an error if zero or several are found.
Add a test covering the fallback path.
Generated by Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* Bump foldseek/createdb and foldseek/easysearch to 10.941cd33
- Update conda env and biocontainers to foldseek 10.941cd33
- easysearch: discover the main DB basename via its .lookup file instead
of misusing ext.prefix2/meta2.id
- Add maintainers and .m8 EDAM ontology to meta.yml
- Fix stub test name and regenerate snapshots
Generated by Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* foldseek/easysearch: select DB via meta2.id, fail fast on lookup fallback
Use ${db}/${meta2.id} when it exists so pipelines can still pick a
database in a multi-DB directory; otherwise fall back to the single
.lookup file and exit with an error if zero or several are found.
Add a test covering the fallback path.
Generated by Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Bump foldseek/createdb and foldseek/easysearch to 10.941cd33
- Update conda env and biocontainers to foldseek 10.941cd33
- easysearch: discover the main DB basename via its .lookup file instead
of misusing ext.prefix2/meta2.id
- Add maintainers and .m8 EDAM ontology to meta.yml
- Fix stub test name and regenerate snapshots
Generated by Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* foldseek/easysearch: select DB via meta2.id, fail fast on lookup fallback
Use ${db}/${meta2.id} when it exists so pipelines can still pick a
database in a multi-DB directory; otherwise fall back to the single
.lookup file and exit with an error if zero or several are found.
Add a test covering the fallback path.
Generated by Claude Opus 5.5
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
* Bump mgnifam/generatefamilies to 3.1.0 and add stats output mgnifam 3.1.0 writes <chunk>_stats.json, a MultiQC-ready run summary. Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * pigz/compress stub fix (nf-core#13015) .gz files should be properly created * Read eggnogmapper's version from package metadata (nf-core#13016) eggnog-mapper's get_version() runs `git describe --tags` with cwd set to its own installed package directory, and only falls back to __VERSION__ when that fails. Under conda the package is installed inside the pipeline's own checkout, so `emapper.py --version` prints that repository's tag rather than the tool's version: emapper-1.4.1-184-g1b3550e / Expected eggNOG DB version: 5.0.2 / ... The module's grep then reported 1.4.1 (a metatdenovo release tag) instead of 2.1.13. Container installs sit outside any repository, and the biocontainer has no git, so they were unaffected and the drift only showed up in a pipeline's conda CI. importlib.metadata reads the installed distribution's own metadata, which no surrounding repository can influence. The package name is passed through sys.argv to keep the expression free of nested quotes, which nf-core modules lint's main.nf parser does not handle. Claude-Session: https://claude.ai/code/session_01LydWahEnWZexTULEub5bfX Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * checkm2/predict: pass database via CHECKM2DB and use small test DB (nf-core#13019) CheckM2 enforces a hardcoded checksum on databases passed with --database_path, but not on the one set through the CHECKM2DB environment variable. Using the env var allows reduced databases, so the test now uses the small DB from test-datasets instead of downloading the full CheckM2 database. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * gffread: accept gzipped gff and fasta input (nf-core#13024) * gffread: accept gzipped gff and fasta input gffread cannot read gzip: a gzipped gff silently yields no features and a gzipped fasta fails with "sequence lines in a FASTA record must have the same length". Stream a gzipped gff through stdin, and decompress a gzipped fasta to a temporary file, removed afterwards so it does not match the *.fasta output glob. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UvGYU6kuXJeVv9ffdSzdzH * Update modules/nf-core/gffread/main.nf Co-authored-by: Paolo Inglese <26252284+piplus2@users.noreply.github.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paolo Inglese <26252284+piplus2@users.noreply.github.com> * Bump foldseek/createdb and foldseek/easysearch to 10.941cd33 (nf-core#13027) * Bump foldseek/createdb and foldseek/easysearch to 10.941cd33 - Update conda env and biocontainers to foldseek 10.941cd33 - easysearch: discover the main DB basename via its .lookup file instead of misusing ext.prefix2/meta2.id - Add maintainers and .m8 EDAM ontology to meta.yml - Fix stub test name and regenerate snapshots Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * foldseek/easysearch: select DB via meta2.id, fail fast on lookup fallback Use ${db}/${meta2.id} when it exists so pipelines can still pick a database in a multi-DB directory; otherwise fall back to the single .lookup file and exit with an error if zero or several are found. Add a test covering the fallback path. Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat: update trna to add all optional outputs (nf-core#13029) * feat: update trna to add all optional outputs * fix: snapshots * Add taxonkit/lca module (nf-core#13023) * Add taxonkit/lca module * Restructure taxonkit/lca input error checking* *Add tests to confirm the module appropriately fails if neither taxids, nor a file containing taxids are passed and if both are passed * Fix precommit format issue in taxonkit/lca * Fix trailing whitespace issue for taxonkit/lca * Remove `MINIMAC4` sites input (nf-core#13022) * Fix miniconda version * Remove sites options from minimac4 * Update test * Add --sites argument as output * Set to optional * Add ontology --------- Co-authored-by: Kevin-Brockers <57921086+Kevin-Brockers@users.noreply.github.com> * New module: xengsort/classify (nf-core#12864) * initiated module template * added xengsort classify module * added xengsort classify tests * updated testing to only check for file existance * trimmed some whitespaces * minor formatting correction * updated testing * classify tests are now run on single thread * actual single thread adjustments * updated snapshot * defining unstable outputs * nf-test single-end graft output is empty and therefore unstable * removed graft from unstable keys * removed params.classify_args from nextflow.config * New module: samtools/trimheader (nf-core#13035) * New module: samtools/trimheader Removes @sq lines for references without reads, re-encoding every record against the smaller header. featureCounts (Subread 2.1.1) cannot read a BAM header over 2 GiB, which a fragmented assembly of about 75M contigs produces. samtools reheader cannot do this, since it leaves record reference ids as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LydWahEnWZexTULEub5bfX * Update modules/nf-core/samtools/trimheader/tests/main.nf.test Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> * Key readsMD5 on the bam channel and regenerate the snapshot Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LydWahEnWZexTULEub5bfX --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> * Fix interproscan ignoring staged database (nf-core#13032) interproscan.sh cd's into its install dir before reading INTERPROSCAN_CONF, so the relative path resolved to the container's own properties file and the bundled sample data was always used. Use an absolute INTERPROSCAN_CONF, point data.directory at the staged data/ folder and bin.directory at the InterProScan bin folder. Drop Hamap from the database test: the test data ships hamap/2023_05, whereas InterProScan 5.59-91 expects hamap/2021_04. Document the database requirements in meta.yml. Closes nf-core#13009 Generated by Claude Opus 5.5 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Update conda-incubator/setup-miniconda digest to be893c9 * fix(hmmer/eslsfetchindex): use GNU sort for large indexes (nf-core#13041) * fix(hmmer/eslsfetchindex): use GNU sort for large indexes Add Coreutils to the module environment and Wave containers so sort can spill to TMPDIR. Report the Coreutils version and document temporary disk use. Generated by Codex * remove empty config file * feat(rsem,dupradar): make temp-file scratch location overridable via ext.args (nf-core#13043) * feat(rsem,dupradar): make temp-file scratch location overridable via ext.args Both RSEM_CALCULATEEXPRESSION/SENTIEON_RSEMCALCULATEEXPRESSION's --temporary-folder and DUPRADAR's featureCounts tmpDir are currently hardcoded to a path relative to the task's working directory, with no way to point them elsewhere. On some network/object-storage-backed work directories (Fusion, NFS, Lustre), the tools' own scratch I/O can be a meaningful cost, and pipelines that have a genuine local scratch mount available have no way to use it without forking the module. This only adds an opt-in override, defaulting exactly as before: - RSEM: ext.args can now include --temporary-folder, guarded the same way many other nf-core modules guard a default CLI flag. - dupradar: a new tmp_dir option, parsed by the template's existing parse_args() mechanism (same pattern already used for feature_type), forwarded to analyzeDuprates()'s tmpDir, which dupRadar itself passes through to Rsubread::featureCounts. Context: nf-core/rnaseq#1957, nf-core/rnaseq#1962 * fix(dupradar): create tmp_dir if it doesn't already exist featureCounts doesn't create its own tmpDir - the default '.' always already exists so this was never visible before, but a custom tmp_dir override fails outright ("temporary directory is not writable") unless something creates it first. Verified locally: without this, overriding tmp_dir fails; with it, featureCounts picks it up and uses it correctly. * fix(dupradar): don't suppress dir.create warnings for tmp_dir showWarnings=FALSE hid the one diagnostic (dir.create's own warning naming the actual OS-level reason) that would explain why a custom tmp_dir couldn't be created, leaving only featureCounts' own less specific "not writable" error. Only call dir.create when the path doesn't already exist (so the default "." case never touches this at all), then explicitly verify existence and writability with a clear error naming the path. * fix(rsem/calculateexpression): remove unused publishDir causing setup failure The "homo_sapiens - bam" test's alignment.config set a publishDir referencing params.outdir, but the test's `then` block only ever asserts on process.out directly via snapshot() - nothing reads from a published path. That publishDir also applied to RSEM_PREPAREREFERENCE, run in this test's `setup` block before `when.params.outdir` is set, so every run failed with "Access to undefined parameter `outdir`" regardless of anything this PR changes. Checked the other modules sharing this same publishDir/outdir config pattern (bcl2fastq, lima, pycoqc, rseqc/bamstat, rseqc/inferexperiment, spring/decompress, subread/featurecounts) - none combine it with a setup dependency, so this exact conflict hasn't come up before. * fix(rsem/calculateexpression): remove second unused publishDir/outdir instance Same issue as the previous commit, in nextflow.config (used by the "fastq" and "stub" tests) rather than alignment.config. The "stub" test's own when block never set params.outdir at all - it only happened to pass when run together with the other tests in this file, because nf-test carries params state across sequential tests in the same run. CI shards tests individually, which exposed it. Removed the now-pointless params.outdir assignments from "bam" and "fastq" too, since nothing reads a published path in any of these tests' assertions. * Add octopusv submodules - filter + subset (nf-core#13040) * Add octopusv submodules - filter + subset * update tests * address review feedback * Update `bcftools_mpileup` (nf-core#13047) * Update bcftools mpileup * Update meta * Fix test * Fix test * Add parabricks/deepsomatic (nf-core#12797) * Add parabricks/deepsomatic * fix tests, use data with accepted readgroup values * remove hallucinated field --------- Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de> Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io> * Bump mgnifam/generatefamilies to 4.0.0 mgnifam 4.0.0 renames the MultiQC summary to <chunk>_mgnifam_stats.json and reorders/renames the metadata CSV columns. Point the documentation link to the new docs site. Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Matthieu Muffato <mm49@sanger.ac.uk> Co-authored-by: Daniel Lundin <erik.rikard.daniel@gmail.com> Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com> Co-authored-by: Paolo Inglese <26252284+piplus2@users.noreply.github.com> Co-authored-by: Jim Downie <19718667+prototaxites@users.noreply.github.com> Co-authored-by: jcbioinformatics <60235622+jcbioinformatics@users.noreply.github.com> Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> Co-authored-by: Kevin-Brockers <57921086+Kevin-Brockers@users.noreply.github.com> Co-authored-by: Leon Hornich <82643611+LeonHornich@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jonathan Manning <jonathan.manning@seqera.io> Co-authored-by: Manas <manas.sehgal@dkfz.de> Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de> Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io>
* Bump mgnifam/updatefamilies to 3.1.0 and add stats output mgnifam 3.1.0 writes <chunk>_updated_stats.json, a MultiQC-ready run summary. Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * pigz/compress stub fix (nf-core#13015) .gz files should be properly created * Read eggnogmapper's version from package metadata (nf-core#13016) eggnog-mapper's get_version() runs `git describe --tags` with cwd set to its own installed package directory, and only falls back to __VERSION__ when that fails. Under conda the package is installed inside the pipeline's own checkout, so `emapper.py --version` prints that repository's tag rather than the tool's version: emapper-1.4.1-184-g1b3550e / Expected eggNOG DB version: 5.0.2 / ... The module's grep then reported 1.4.1 (a metatdenovo release tag) instead of 2.1.13. Container installs sit outside any repository, and the biocontainer has no git, so they were unaffected and the drift only showed up in a pipeline's conda CI. importlib.metadata reads the installed distribution's own metadata, which no surrounding repository can influence. The package name is passed through sys.argv to keep the expression free of nested quotes, which nf-core modules lint's main.nf parser does not handle. Claude-Session: https://claude.ai/code/session_01LydWahEnWZexTULEub5bfX Co-authored-by: Claude Opus 5 <noreply@anthropic.com> * checkm2/predict: pass database via CHECKM2DB and use small test DB (nf-core#13019) CheckM2 enforces a hardcoded checksum on databases passed with --database_path, but not on the one set through the CHECKM2DB environment variable. Using the env var allows reduced databases, so the test now uses the small DB from test-datasets instead of downloading the full CheckM2 database. Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com> * gffread: accept gzipped gff and fasta input (nf-core#13024) * gffread: accept gzipped gff and fasta input gffread cannot read gzip: a gzipped gff silently yields no features and a gzipped fasta fails with "sequence lines in a FASTA record must have the same length". Stream a gzipped gff through stdin, and decompress a gzipped fasta to a temporary file, removed afterwards so it does not match the *.fasta output glob. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01UvGYU6kuXJeVv9ffdSzdzH * Update modules/nf-core/gffread/main.nf Co-authored-by: Paolo Inglese <26252284+piplus2@users.noreply.github.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Paolo Inglese <26252284+piplus2@users.noreply.github.com> * Bump foldseek/createdb and foldseek/easysearch to 10.941cd33 (nf-core#13027) * Bump foldseek/createdb and foldseek/easysearch to 10.941cd33 - Update conda env and biocontainers to foldseek 10.941cd33 - easysearch: discover the main DB basename via its .lookup file instead of misusing ext.prefix2/meta2.id - Add maintainers and .m8 EDAM ontology to meta.yml - Fix stub test name and regenerate snapshots Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> * foldseek/easysearch: select DB via meta2.id, fail fast on lookup fallback Use ${db}/${meta2.id} when it exists so pipelines can still pick a database in a multi-DB directory; otherwise fall back to the single .lookup file and exit with an error if zero or several are found. Add a test covering the fallback path. Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * feat: update trna to add all optional outputs (nf-core#13029) * feat: update trna to add all optional outputs * fix: snapshots * Add taxonkit/lca module (nf-core#13023) * Add taxonkit/lca module * Restructure taxonkit/lca input error checking* *Add tests to confirm the module appropriately fails if neither taxids, nor a file containing taxids are passed and if both are passed * Fix precommit format issue in taxonkit/lca * Fix trailing whitespace issue for taxonkit/lca * Remove `MINIMAC4` sites input (nf-core#13022) * Fix miniconda version * Remove sites options from minimac4 * Update test * Add --sites argument as output * Set to optional * Add ontology --------- Co-authored-by: Kevin-Brockers <57921086+Kevin-Brockers@users.noreply.github.com> * New module: xengsort/classify (nf-core#12864) * initiated module template * added xengsort classify module * added xengsort classify tests * updated testing to only check for file existance * trimmed some whitespaces * minor formatting correction * updated testing * classify tests are now run on single thread * actual single thread adjustments * updated snapshot * defining unstable outputs * nf-test single-end graft output is empty and therefore unstable * removed graft from unstable keys * removed params.classify_args from nextflow.config * New module: samtools/trimheader (nf-core#13035) * New module: samtools/trimheader Removes @sq lines for references without reads, re-encoding every record against the smaller header. featureCounts (Subread 2.1.1) cannot read a BAM header over 2 GiB, which a fragmented assembly of about 75M contigs produces. samtools reheader cannot do this, since it leaves record reference ids as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LydWahEnWZexTULEub5bfX * Update modules/nf-core/samtools/trimheader/tests/main.nf.test Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> * Key readsMD5 on the bam channel and regenerate the snapshot Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LydWahEnWZexTULEub5bfX --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> * Fix interproscan ignoring staged database (nf-core#13032) interproscan.sh cd's into its install dir before reading INTERPROSCAN_CONF, so the relative path resolved to the container's own properties file and the bundled sample data was always used. Use an absolute INTERPROSCAN_CONF, point data.directory at the staged data/ folder and bin.directory at the InterProScan bin folder. Drop Hamap from the database test: the test data ships hamap/2023_05, whereas InterProScan 5.59-91 expects hamap/2021_04. Document the database requirements in meta.yml. Closes nf-core#13009 Generated by Claude Opus 5.5 Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> * Update conda-incubator/setup-miniconda digest to be893c9 * fix(hmmer/eslsfetchindex): use GNU sort for large indexes (nf-core#13041) * fix(hmmer/eslsfetchindex): use GNU sort for large indexes Add Coreutils to the module environment and Wave containers so sort can spill to TMPDIR. Report the Coreutils version and document temporary disk use. Generated by Codex * remove empty config file * feat(rsem,dupradar): make temp-file scratch location overridable via ext.args (nf-core#13043) * feat(rsem,dupradar): make temp-file scratch location overridable via ext.args Both RSEM_CALCULATEEXPRESSION/SENTIEON_RSEMCALCULATEEXPRESSION's --temporary-folder and DUPRADAR's featureCounts tmpDir are currently hardcoded to a path relative to the task's working directory, with no way to point them elsewhere. On some network/object-storage-backed work directories (Fusion, NFS, Lustre), the tools' own scratch I/O can be a meaningful cost, and pipelines that have a genuine local scratch mount available have no way to use it without forking the module. This only adds an opt-in override, defaulting exactly as before: - RSEM: ext.args can now include --temporary-folder, guarded the same way many other nf-core modules guard a default CLI flag. - dupradar: a new tmp_dir option, parsed by the template's existing parse_args() mechanism (same pattern already used for feature_type), forwarded to analyzeDuprates()'s tmpDir, which dupRadar itself passes through to Rsubread::featureCounts. Context: nf-core/rnaseq#1957, nf-core/rnaseq#1962 * fix(dupradar): create tmp_dir if it doesn't already exist featureCounts doesn't create its own tmpDir - the default '.' always already exists so this was never visible before, but a custom tmp_dir override fails outright ("temporary directory is not writable") unless something creates it first. Verified locally: without this, overriding tmp_dir fails; with it, featureCounts picks it up and uses it correctly. * fix(dupradar): don't suppress dir.create warnings for tmp_dir showWarnings=FALSE hid the one diagnostic (dir.create's own warning naming the actual OS-level reason) that would explain why a custom tmp_dir couldn't be created, leaving only featureCounts' own less specific "not writable" error. Only call dir.create when the path doesn't already exist (so the default "." case never touches this at all), then explicitly verify existence and writability with a clear error naming the path. * fix(rsem/calculateexpression): remove unused publishDir causing setup failure The "homo_sapiens - bam" test's alignment.config set a publishDir referencing params.outdir, but the test's `then` block only ever asserts on process.out directly via snapshot() - nothing reads from a published path. That publishDir also applied to RSEM_PREPAREREFERENCE, run in this test's `setup` block before `when.params.outdir` is set, so every run failed with "Access to undefined parameter `outdir`" regardless of anything this PR changes. Checked the other modules sharing this same publishDir/outdir config pattern (bcl2fastq, lima, pycoqc, rseqc/bamstat, rseqc/inferexperiment, spring/decompress, subread/featurecounts) - none combine it with a setup dependency, so this exact conflict hasn't come up before. * fix(rsem/calculateexpression): remove second unused publishDir/outdir instance Same issue as the previous commit, in nextflow.config (used by the "fastq" and "stub" tests) rather than alignment.config. The "stub" test's own when block never set params.outdir at all - it only happened to pass when run together with the other tests in this file, because nf-test carries params state across sequential tests in the same run. CI shards tests individually, which exposed it. Removed the now-pointless params.outdir assignments from "bam" and "fastq" too, since nothing reads a published path in any of these tests' assertions. * Add octopusv submodules - filter + subset (nf-core#13040) * Add octopusv submodules - filter + subset * update tests * address review feedback * Update `bcftools_mpileup` (nf-core#13047) * Update bcftools mpileup * Update meta * Fix test * Fix test * Add parabricks/deepsomatic (nf-core#12797) * Add parabricks/deepsomatic * fix tests, use data with accepted readgroup values * remove hallucinated field --------- Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de> Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io> * Bump mgnifam/updatefamilies to 4.0.0 mgnifam 4.0.0 renames the MultiQC summary to <chunk>_updated_mgnifam_stats.json, reorders/renames the metadata CSV columns and leaves `converged` empty under --skip_refine. Point the documentation link to the new docs site. Generated by Claude Opus 5.5 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Matthieu Muffato <mm49@sanger.ac.uk> Co-authored-by: Daniel Lundin <erik.rikard.daniel@gmail.com> Co-authored-by: Diego Alvarez S. <dialvarezs@gmail.com> Co-authored-by: Paolo Inglese <26252284+piplus2@users.noreply.github.com> Co-authored-by: Jim Downie <19718667+prototaxites@users.noreply.github.com> Co-authored-by: jcbioinformatics <60235622+jcbioinformatics@users.noreply.github.com> Co-authored-by: Louis Le Nézet <58640615+LouisLeNezet@users.noreply.github.com> Co-authored-by: Kevin-Brockers <57921086+Kevin-Brockers@users.noreply.github.com> Co-authored-by: Leon Hornich <82643611+LeonHornich@users.noreply.github.com> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jonathan Manning <jonathan.manning@seqera.io> Co-authored-by: Manas <manas.sehgal@dkfz.de> Co-authored-by: Simon Pearce <24893913+SPPearce@users.noreply.github.com> Co-authored-by: Friederike Hanssen <Friederike.hanssen@qbic.uni-tuebingen.de> Co-authored-by: Friederike Hanssen <friederike.hanssen@seqera.io>
Bumps both foldseek modules from
9.427df8ato the latest bioconda release10.941cd33and brings them to current standards.environment.yml/ containers updated to10.941cd33(10.941cd33--h5021889_1).foldseek/easysearch: the main database basename inside thedbdirectory is now auto-discovered via its.lookupfile, instead of usingext.prefix2/meta2.id(ext.prefix2is reserved for a second output prefix). Channel structure and emit names are unchanged.meta.yml: addedmaintainers, EDAM ontology for the.m8output, updateddbdescription.- stub), updated the expected hit line (bit score 1523 → 1526 in v10), regenerated snapshots.Note:
nf-core modules lintreportsbioconda_latest: bioconda::foldseek 10.941cd33 -> 8.ef4e960— a false positive caused by foldseek's<major>.<hash>versioning;10.941cd33is the latest release.Generated by Claude Opus 5.5
PR checklist
topic: versions- See version_topicslabelnf-core modules test <MODULE> --profile dockernf-core modules test <MODULE> --profile singularitynf-core modules test <MODULE> --profile conda🤖 Generated with Claude Code