Repository navigation
new module: spatialcontinuumtranslational/gist - #13794
Conversation
|
Hi @vagkaratzas, @famosab! 👋 Whenever you have a chance, Thanks a lot! |
vagkaratzas
left a comment
There was a problem hiding this comment.
- Please add test coverage for the
--format tsvoutput branch and the other input formats (CSV, JSON); the tsv output is currently never exercised. - Use
${prefix}-based output paths instead of globs, and make the format detection robust. - Mark optional outputs as "Optional" in
meta.yml, and trim the PR body (the self-reported review score is not needed; tick/adjust the conda/singularity boxes to match what CI ran).
Gates: G1 and G2 from CI (all lint and nf-test jobs green on conda, docker, singularity), G3 (nextflow lint) run locally, no errors.
Diff 8.93/10 · Overall 8.93/10
nf-core-reviewer 0.8.0dev / vagkaratzas-review (rubric v7) · claude-sonnet-5-5
| tuple val(meta), path("*_gist.json"), emit: json, optional: true | ||
| tuple val(meta), path("*_gist.tsv"), emit: tsv, optional: true |
There was a problem hiding this comment.
The output names are predictable from ${prefix} and the format, so use them instead of globs, e.g. path("${prefix}_gist.json"). Note args.contains('--format tsv') misses --format=tsv or extra spaces, which would write TSV content into a .json file; consider a more robust check
| tag "spatialcontinuumtranslational" | ||
| tag "spatialcontinuumtranslational/gist" | ||
|
|
||
| test("homosapiens - tsv - json") { |
There was a problem hiding this comment.
Only the JSON-default path is covered. Add a test with params { module_args = '--format tsv' } (this needs a tests/nextflow.config with ext.args = { params.module_args ?: '' }) and ideally CSV and JSON inputs, so each branch can fail when removed
| e.g. `[ id:'sample1' ]` | ||
| - "*_gist.json": | ||
| type: file | ||
| description: GIST phenotype research profile score in JSON format |
There was a problem hiding this comment.
Both outputs are optional: true, so the descriptions should start with "Optional", here and at line 56
…output paths and mark optional outputs
|
Thanks a lot for the review @vagkaratzas! 🙏 I have addressed all points:
|
…rgs pattern and T10 unique snapshots
|
Minor polish update: refactored to use (rubric rule T7) and updated input covariates on the JSON test to ensure distinct snapshot entries across formats (rubric rule T10). All 4 tests passing cleanly. |
vagkaratzas
left a comment
There was a problem hiding this comment.
- No blocking issues found: lint, nf-test (CI) and strict
nextflow lintall pass, and the module follows the current conventions. - Optional: the README lists the tool on bio.tools (
spatial-continuum-translational), soidentifierinmeta.ymlcould bebiotools:spatial-continuum-translationalinstead of"". - Optional: the output extension is derived by regex-parsing
ext.argsfor--format/-f, which is a little fragile; it works for the tested cases, so fine to keep.
Approval should be on its way soon.
Diff 10.00/10 · Overall 10.00/10
nf-core-reviewer 0.8.0dev / vagkaratzas-review (rubric v7) · claude-sonnet-5-5
|
Hi @vagkaratzas! 👋 Applied the optional suggestion: added Ready for approval whenever convenient — thank you! 🙏 |
Adds
spatialcontinuumtranslational/gist, which calculates deterministic, research-only Gastrointestinal Stromal Tumor (GIST) phenotype profiles and risk stratification from cohort TSV, CSV, or JSON data with spatial-continuum-translational (Celebrano et al. 2026).Notes for review
spatial-continuum-translational=0.1.53(Add spatial-continuum-translational bioconda/bioconda-recipes#71345, merged). Multi-architecture Wave container images (amd64/arm64) and lockfiles in.conda-lock/were generated withnf-core modules containers create.nf-core modules lint: 74/74 tests passed, 0 warnings, 0 failures).nf-testtests verify standard cohort inputs across TSV, CSV, and JSON, exercising both default JSON and--format tsvoutput branches, as well as stub run (-stub). Snapshots verified inmain.nf.test.snap.topic: versionsemit without hardcoded versions or precompiled stubs, and valid EDAM ontologies (format_3475# TSV,format_3752# CSV,format_3464# JSON).PR checklist
topic: versions- See version_topicslabelnf-test test modules/nf-core/spatialcontinuumtranslational/gist/tests/main.nf.test --profile=dockernf-test test modules/nf-core/spatialcontinuumtranslational/gist/tests/main.nf.test --profile=singularitynf-test test modules/nf-core/spatialcontinuumtranslational/gist/tests/main.nf.test --profile=conda