Repository navigation
new module: spatialsanctuary/simulate - #13797
Conversation
|
Hi @vagkaratzas, @famosab! 👋 Following up on the spatial biophysics module series (along with Thank you as always! |
vagkaratzas
left a comment
There was a problem hiding this comment.
- Blocking: the four scalar
valinputs should beext.argsflags, not module inputs. - Not blocking: the snapshot records
spatial-sanctuaryversion2.2.1whileenvironment.ymland the lock files pin2.2.2. Theimportlib.metadataversion probably comes from a stale package version string; please check that the emitted version matches the pinned one. - Gates: G1, G2 and G3 pass.
Not run: nothing. G1 and G2 come from CI, G3 was run locally.
Diff 9.67/10 · Overall 9.67/10
nf-core-reviewer 0.8.0dev / vagkaratzas-review (rubric v7) · claude-sonnet-5-5
| : 'community.wave.seqera.io/library/spatial-sanctuary:2.2.2--da11ed94efb15111'}" | ||
|
|
||
| input: | ||
| tuple val(meta), val(modality), val(c0), val(theta), val(r_ox) |
There was a problem hiding this comment.
modality, c0, theta and r_ox are plain val inputs that map to tool flags with defaults (the tool README runs simulate --c0 40.0 --lambda-um 627.65 --theta 0.35 with no modality or --r-ox). Move them to ext.args (set through params.module_args in the tests).
|
Thanks a lot for the review @vagkaratzas! 🙏 I have addressed the points:
|
|
Minor polish update: refactored to follow the standard closure pattern (rubric rule T7). All local lint and docker nf-tests passing cleanly. |
There was a problem hiding this comment.
- Nothing blocking: lint, nf-test (all profiles) and
nextflow lintpass, and the module follows the conventions. - The PR description should be corrected (see below).
Please update the PR description: remove the "Vagkaratzas Review score" line, since it is not a review result, and tick or run the checklist item for the profiles CI used rather than quoting --profile=docker only.
While you are here (not blocking):
- tests/main.nf.test.snap:19: the version recorded is
2.2.1whileenvironment.ymlpinsspatial-sanctuary=2.2.2. The package metadata seems not to have been bumped upstream; worth checking the eval reports the real version.
Gates: G1 and G2 from CI (green on head), G3 run locally with Nextflow 26.04.0 (no errors).
Diff 9.84/10 · Overall 9.84/10
nf-core-reviewer 0.8.0dev / vagkaratzas-review (rubric v7) · claude-sonnet-5-5
|
Hi @vagkaratzas! 👋 Thank you for the review! As requested, I have updated the PR description:
Thank you again! 🙏 |
Adds
spatialsanctuary/simulate, which calculates steady-state radial reaction-diffusion concentration profiles (Bessel K0 solver) and pharmacological sanctuary shell geometry in avascular tumor cords for Osimertinib (TKI) and antibody-drug conjugates (ADCs) with spatial-sanctuary (Celebrano et al. 2026).Notes for review
spatial-sanctuary=2.2.2(Update spatial-sanctuary to 2.2.2 bioconda/bioconda-recipes#70840, merged). Multi-architecture Wave container images (amd64/arm64) and lockfiles in.conda-lock/were generated withnf-core modules containers create.nf-core modules lint: 71/71 tests passed, 0 warnings, 0 failures).nf-testtests passed both for standard biophysical input parameters and for stub run (-stub). Snapshots verified and committed inmain.nf.test.snap.topic: versionsemit without hardcoded versions or precompiled stubs, and valid EDAM ontology format comments (format_3464# JSON).PR checklist
topic: versions- See version_topicslabelnf-test test modules/nf-core/spatialsanctuary/simulate/tests/main.nf.test --profile=dockernf-test test modules/nf-core/spatialsanctuary/simulate/tests/main.nf.test --profile=singularitynf-test test modules/nf-core/spatialsanctuary/simulate/tests/main.nf.test --profile=conda