Repository navigation
Preparing v4.2.2 LTS Maintenance #50
Description
@nodejs/lts ... preparing for the v4.2.2 LTS Maintenance release... Here's the list of candidate commits currently sitting in v4.x-staging. Please let me know if any of these SHOULD NOT be in the v4.2.2 release (https://github.com/nodejs/node/commits/v4.x-staging)
List of commits in v4.x-staging: #50 (comment)
List of commits remaining in master: #50 (comment)
/cc @nodejs/collaborators
Metadata
Metadata
Assignees
Labels
No labels
Activity
rvagg commentedon Oct 28, 2015
I've just published a new version of
branch-diffwith a--patch-onlycommandline option so we can see what the candidates are, I think that adding a--start-refmight help too so we can limit the list to only those within a certain date range (e.g.--start-ref=v4.2.2), but that can come later.For the purpose of looking at the commits that are still candidates because that's worth discussing too.
b52142fe80] - Working on 6.0.0 (Rod Vagg)0a7076b0f1] - 2015-10-13, Version 4.2.1 'Argon' (LTS) Release (James M Snell)4a6f1feecb] - 2015-09-22, Version 4.1.1 (Stable) Release (Rod Vagg) #2995b9813641dc] - 2015-09-15 io.js v3.3.1 Release (Rod Vagg) #2698380a3d89c3] - 2015-09-08, Version 4.0.0 (Stable) Release (Rod Vagg) #274242a8a0a53e] - Working on v5.0.0 (Rod Vagg)15bcbf853e] - build: Updates for AIX npm support - part 1 (Michael Dawson) #3114753509f579] - build: rectify --link-module help text (P.S.V.R) #33796456fcf4f3] - deps: update V8 to 4.6.85.28 (Michaël Zasso) #348468471dd37c] - deps: fix upgrade to npm 3.3.6 (Rebecca Turner) #349441923c0c07] - deps: upgrade npm to 3.3.6 (Rebecca Turner) #3310a334ddc467] - _Revert_ "deps: backport 03ef3cd from V8 upstream" (Ali Ijaz Sheikh) #32376fff47ffac] - deps: backport 03ef3cd from V8 upstream (Ali Ijaz Sheikh) #3165680dda8023] - dns: remove nonexistant exports.ADNAME (Roman Reiss) #3051052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #34800a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463d381290854] - doc: more use-cases for promise events (Domenic Denicola) #3438829eb97fef] - doc: update WORKING_GROUPS.md - add missing groups (Michael Dawson) #3450cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235b78de124d6] - doc: add TSC meeting minutes 2015-10-07 (Rod Vagg) #3364a441aa6e1d] - doc: update WORKING_GROUPS.md to include Intl (Steven R. Loomis) #32513ef2e4acf3] - doc: fix typos in changelog (reggi) #3291b9279aa193] - doc: remove old note, 'cluster' is marked stable (Balázs Galambosi) #3314cdfa271164] - doc: update AUTHORS list (Rod Vagg)aaf9b488e2] - lib,test: update let to const where applicable (Sakthipriyan Vairamani) #31529adc6a6bd0] - lttng: update flags for gc tracing (Glen Keane) #3388494227bb03] - node: improve GetActiveRequests performance (Trevor Norris) #337553e64bb29e] - src: fix race condition in debug signal on exit (Ben Noordhuis) #3528a3b238a0d0] - src: bump NODE_MODULE_VERSION To 47 (Rod Vagg) #34002d3560767e] - src: fix exception message encoding on Windows (Brian White) #3288ff877e93e1] - src: fix stuck debugger process (Liang-Chi Hsieh) #27783a091d29bf] - test: add node::MakeCallback() test coverage (Ben Noordhuis) #3478642928b502] - test: port domains regression test from v0.10 (Jonas Dohse) #33566f14b3a7db] - test: remove util from common (Rich Trott) #33247d94611ac9] - test: split up buffer tests for reliability (Rich Trott) #33233202456baa] - test: remove util properties from common (Rich Trott) #330431c971d641] - test: parallelize long-running test (Rich Trott) #32875bbc6df7de] - test: change call to deprecated util.isError() (Rich Trott) #30843eecdf9f14] - timers: reuse timer insetTimeout().unref()(Fedor Indutny) #3407b0e7b362c2] - tools: enable prefer-const eslint rule (Sakthipriyan Vairamani) #31529b8886446d] - tools: ensure npm always uses the local node (Jeremiah Senkpiel) #3489349fbe96ae] - tools: update test-npm to work with npm 3 (Rebecca Turner) #3489f5445db4cd] - tools: use absolute paths in test-npm (Rebecca Turner) #33091cbc2d05b5] - v8: pull fix for builtin code size on PPC (Michael Dawson) #3474b244f139bf] - vm: remove Watchdog dependency on Environment (Ido Ben-Yair) #3274rvagg commentedon Oct 28, 2015
I'm not meaning to spam here, but this is @jasnell's original list shown in the standard format, grouped (also demonstrating how
branch-diffandchangelog-makercan be used here):bc2120caa1] - buffer: fix value check for writeUInt{B,L}E (Trevor Norris) #3500287e8306fd] - buffer: don't CHECK on zero-sized realloc (Ben Noordhuis) #34999061aa2a75] - deps: backport 8d6a228 from the v8's upstream (Fedor Indutny) #3549e223fc7499] - doc: fix indent in tls resumption example (Roman Reiss) #337231a9ecf504] - doc: fix typo in changelog (Timothy Gu) #3353925953d1bc] - doc: show keylen in pbkdf2 as a byte length (calebboyd) #33344023c7dc34] - doc: add information about Assert behavior and maintenance (Rich Trott) #33304afcf5732b] - doc: clarify API buffer.concat (Martii) #3255282618e237] - doc: clarify the use ofoption.detached(Kyle Smith) #3250240046ccc6] - doc: binary encoding is not deprecated (Trevor Norris) #344147ab7c76f0] - docs: add missing shell option to execSync (fansworld-claudio) #3440fb3b8489de] - fs: reduced duplicate code in fs.write() (ronkorving) #294787f8ccfe35] - http: fix stalled pipeline bug (Fedor Indutny) #3342e4417a1bfa] - lib: fix cluster handle leak (Rich Trott) #35101888f84204] - lib: avoid REPL exit on completion error (Rich Trott) #3358594e8e7a54] - repl: limit persistent history correctly on load (Jeremiah Senkpiel) #23565db1f070fe] - stream: avoid unnecessary concat of a single buffer. (Calvin Metcalf) #3300172cccfe0c] - stream: fix signature of _write() in a comment (Fábio Santos) #324812d83858f7] - test: improve tests for util.inherits (Michaël Zasso) #35079e05af7d31] - test: print helpful err msg on test-dns-ipv6.js (Junliang Yan) #35015222fcc117] - test: fix domain with abort-on-uncaught on PPC (Julien Gilli) #33549fa8c32d35] - test: cleanup, improve repl-persistent-history (Jeremiah Senkpiel) #23566305d26f40] - test: add Symbol test for assert.deepEqual() (Rich Trott) #3327bc2a80b493] - test: disable test-tick-processor - aix and be ppc (Michael Dawson) #3491304eda46a4] - test: harden test-child-process-fork-regr-gh-2847 (Michael Dawson) #3459e99823bf5a] - test: fix test-net-keepalive for AIX (Imran Iqbal) #3458635f74366f] - test: wrap assert.fail when passed to callback (Myles Borins) #345349549c9b2a] - test: skip test-dns-ipv6.js if ipv6 is unavailable (Junliang Yan) #34443d1f57d9dd] - test: repl-persistent-history is no longer flaky (Jeremiah Senkpiel) #34370b324142ca] - test: fix flaky test-child-process-emfile (Rich Trott) #34300c23e81d7a] - test: remove flaky status from eval_messages test (Rich Trott) #3420d62d15843c] - test: fix flaky test for symlinks (Rich Trott) #3418d540666bfe] - test: apply correct assert.fail() arguments (Rich Trott) #337841a4258f57] - test: replace util with backtick strings (Myles Borins) #3359e43c611be5] - test: add test-child-process-emfile fail message (Rich Trott) #3335f6ea99f67b] - tls: TLSSocket options default isServer false (Yuval Brik) #2614jasnell commentedon Oct 28, 2015
@rvagg .. hope you don't mind, I turned your first list into a checklist so we can more easily reconcile the two lists... the checked items are things that I identify should land in v4.x-staging (if any)
jasnell commentedon Oct 28, 2015
Ok, landed another round of commits based on the checked items above. Here's the updated list of commits in
v4.x-stagingthat are being considered for thev4.2.2release (generated using @rvagg's fancy tools ;-) )bc2120caa1] - buffer: fix value check for writeUInt{B,L}E (Trevor Norris) #3500287e8306fd] - buffer: don't CHECK on zero-sized realloc (Ben Noordhuis) #349977511eb108] - deps: backport 010897c from V8 upstream (Ali Ijaz Sheikh) #35209061aa2a75] - deps: backport 8d6a228 from the v8's upstream (Fedor Indutny) #3549282065f48b] - doc: mention the behaviour if URL is invalid (Sakthipriyan Vairamani) #2966e223fc7499] - doc: fix indent in tls resumption example (Roman Reiss) #337231a9ecf504] - doc: fix typo in changelog (Timothy Gu) #3353925953d1bc] - doc: show keylen in pbkdf2 as a byte length (calebboyd) #33344023c7dc34] - doc: add information about Assert behavior and maintenance (Rich Trott) #33304afcf5732b] - doc: clarify API buffer.concat (Martii) #3255282618e237] - doc: clarify the use ofoption.detached(Kyle Smith) #3250240046ccc6] - doc: binary encoding is not deprecated (Trevor Norris) #344147ab7c76f0] - docs: add missing shell option to execSync (fansworld-claudio) #3440fb3b8489de] - fs: reduced duplicate code in fs.write() (ronkorving) #294787f8ccfe35] - http: fix stalled pipeline bug (Fedor Indutny) #3342e4417a1bfa] - lib: fix cluster handle leak (Rich Trott) #35101888f84204] - lib: avoid REPL exit on completion error (Rich Trott) #3358d918838723] - repl: handle comments properly (Sakthipriyan Vairamani) #3515594e8e7a54] - repl: limit persistent history correctly on load (Jeremiah Senkpiel) #2356c85736eed7] - src: fix race condition in debug signal on exit (Ben Noordhuis) #35289bffceb336] - src: fix exception message encoding on Windows (Brian White) #32885db1f070fe] - stream: avoid unnecessary concat of a single buffer. (Calvin Metcalf) #3300172cccfe0c] - stream: fix signature of _write() in a comment (Fábio Santos) #32482fc13e500c] - test: fix missing unistd.h on windows (Junliang Yan) #353237aec6a97a] - test: add regression test for --debug-brk -e 0 (Ben Noordhuis) #3585b8869bdc27] - test: port domains regression test from v0.10 (Jonas Dohse) #3356d4fced7cb7] - test: remove util from common (Rich Trott) #33244c411ae8f2] - test: remove util properties from common (Rich Trott) #3304a8425abfe5] - test: split up buffer tests for reliability (Rich Trott) #3323c76ef6c20c] - test: parallelize long-running test (Rich Trott) #32875bb6e0f64d] - test: change call to deprecated util.isError() (Rich Trott) #308412d83858f7] - test: improve tests for util.inherits (Michaël Zasso) #35079e05af7d31] - test: print helpful err msg on test-dns-ipv6.js (Junliang Yan) #35015222fcc117] - test: fix domain with abort-on-uncaught on PPC (Julien Gilli) #33549fa8c32d35] - test: cleanup, improve repl-persistent-history (Jeremiah Senkpiel) #23566305d26f40] - test: add Symbol test for assert.deepEqual() (Rich Trott) #3327bc2a80b493] - test: disable test-tick-processor - aix and be ppc (Michael Dawson) #3491304eda46a4] - test: harden test-child-process-fork-regr-gh-2847 (Michael Dawson) #3459e99823bf5a] - test: fix test-net-keepalive for AIX (Imran Iqbal) #3458635f74366f] - test: wrap assert.fail when passed to callback (Myles Borins) #345349549c9b2a] - test: skip test-dns-ipv6.js if ipv6 is unavailable (Junliang Yan) #34443d1f57d9dd] - test: repl-persistent-history is no longer flaky (Jeremiah Senkpiel) #34370b324142ca] - test: fix flaky test-child-process-emfile (Rich Trott) #34300c23e81d7a] - test: remove flaky status from eval_messages test (Rich Trott) #3420d62d15843c] - test: fix flaky test for symlinks (Rich Trott) #3418d540666bfe] - test: apply correct assert.fail() arguments (Rich Trott) #337841a4258f57] - test: replace util with backtick strings (Myles Borins) #3359e43c611be5] - test: add test-child-process-emfile fail message (Rich Trott) #333540bb8024c6] - timers: reuse timer insetTimeout().unref()(Fedor Indutny) #3407f6ea99f67b] - tls: TLSSocket options default isServer false (Yuval Brik) #2614jasnell commentedon Oct 28, 2015
And the updated comparison of
master<==>v4.x-staging... (these are the commits that have not made it into v4.x-staging). #3474 is still an open question about whether it should make it into v4.x-staging or not.[
b52142fe80] - Working on 6.0.0 (Rod Vagg)0a7076b0f1] - 2015-10-13, Version 4.2.1 'Argon' (LTS) Release (James M Snell)4a6f1feecb] - 2015-09-22, Version 4.1.1 (Stable) Release (Rod Vagg) #2995b9813641dc] - 2015-09-15 io.js v3.3.1 Release (Rod Vagg) #2698380a3d89c3] - 2015-09-08, Version 4.0.0 (Stable) Release (Rod Vagg) #274242a8a0a53e] - Working on v5.0.0 (Rod Vagg)15bcbf853e] - build: Updates for AIX npm support - part 1 (Michael Dawson) #3114753509f579] - build: rectify --link-module help text (P.S.V.R) #33796456fcf4f3] - deps: update V8 to 4.6.85.28 (Michaël Zasso) #348468471dd37c] - deps: fix upgrade to npm 3.3.6 (Rebecca Turner) #349441923c0c07] - deps: upgrade npm to 3.3.6 (Rebecca Turner) #3310a334ddc467] - _Revert_ "deps: backport 03ef3cd from V8 upstream" (Ali Ijaz Sheikh) #32376fff47ffac] - deps: backport 03ef3cd from V8 upstream (Ali Ijaz Sheikh) #3165680dda8023] - dns: remove nonexistant exports.ADNAME (Roman Reiss) #3051d394e9e6bb] - doc: add LTS info to COLLABORATOR_GUIDE.md (Myles Borins) #34425d5a4c4c18] - doc: createServer's key option can be an array (Sakthipriyan Vairamani) #3123052611b0d1] - doc: add TSC meeting minutes 2015-10-21 (Rod Vagg) #34800a0926e863] - doc: add TSC meeting minutes 2015-10-14 (Rod Vagg) #3463d381290854] - doc: more use-cases for promise events (Domenic Denicola) #3438829eb97fef] - doc: update WORKING_GROUPS.md - add missing groups (Michael Dawson) #3450cba5d2b948] - doc: add TSC meeting minutes 2015-09-30 (Rod Vagg) #3235b78de124d6] - doc: add TSC meeting minutes 2015-10-07 (Rod Vagg) #3364a441aa6e1d] - doc: update WORKING_GROUPS.md to include Intl (Steven R. Loomis) #32513ef2e4acf3] - doc: fix typos in changelog (reggi) #3291b9279aa193] - doc: remove old note, 'cluster' is marked stable (Balázs Galambosi) #3314cdfa271164] - doc: update AUTHORS list (Rod Vagg)aaf9b488e2] - lib,test: update let to const where applicable (Sakthipriyan Vairamani) #31529adc6a6bd0] - lttng: update flags for gc tracing (Glen Keane) #3388494227bb03] - node: improve GetActiveRequests performance (Trevor Norris) #3375c9e682d587] - test: use port number from env in tls socket test (Stefan Budeanu) #35573a091d29bf] - test: add node::MakeCallback() test coverage (Ben Noordhuis) #3478b0e7b362c2] - tools: enable prefer-const eslint rule (Sakthipriyan Vairamani) #31529b8886446d] - tools: ensure npm always uses the local node (Jeremiah Senkpiel) #3489349fbe96ae] - tools: update test-npm to work with npm 3 (Rebecca Turner) #3489f5445db4cd] - tools: use absolute paths in test-npm (Rebecca Turner) #33091cbc2d05b5] - v8: pull fix for builtin code size on PPC (Michael Dawson) #3474b244f139bf] - vm: remove Watchdog dependency on Environment (Ido Ben-Yair) #3274jasnell commentedon Oct 28, 2015
@rvagg : might be worthwhile having an option on branch-diff to exclude commits whose PRs are tagged as
metarvagg commentedon Oct 28, 2015
was also thinking about an option to include a third branch and have it print a GitHub style checklist where the items that exist on the third branch are already ticked
rvagg commentedon Oct 28, 2015
@jasnell published a new version with
--exclude-labelso you can exclude what you like, provide multiple options to exclude multiple labels or just provide a comma-separated list.--patch-onlyis now just an alias for--exclude-label=semver-major,semver-minorbut in this case--exclude-label=semver-major,semver-minor,metawould be what you're after. This'll also be helpful for excluding onlysemver-minorfrom stable releases.jasnell commentedon Oct 29, 2015
@rvagg +1 ... awesome. How about the commit lists? Going to do the RC build tomorrow morning based on this list.
jasnell commentedon Oct 29, 2015
RC1 build queued up:
https://ci.nodejs.org/job/iojs+release/238/Scratch that... the windows systems on CI are giving me fits. ICU download keeps failing.
Update: Ok, finally kicked it enough and did the right magic incantation for it to work. RC1 build running now
jasnell commentedon Oct 29, 2015
@nodejs/lts @nodejs/collaborators ... v4.2.2-RC1 Builds Here: https://nodejs.org/download/rc/v4.2.2-rc.1/
Please smoke test!! Targeting Monday as the release date
jasnell commentedon Oct 29, 2015
Release Proposal: nodejs/node#3588