You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
More visibility for TSC on performance issues #940
@Trott I'm thinking that the TSC should be aware of significant performance regressions affecting the LTS releases, and any which are known in advance of cutting a new Major release.
I understand that people can go search for them, but it seems to like something we should be more proactive about.
I'm not sure granular awareness is relevant unless we have a plan to act on it (revert offending commits, block releases, etc.). The problem is most of the recent performance issues I've seen reported on our issue tracker are V8 related and not Node.js related, which makes it harder for us to act on it.
Preventing and fixing regressions is definitely important, but I'm wondering if a working group/task force/strategic initiative would make more sense than making the whole TSC aware. If just awareness is wanted, we can list all issues with performance label on meetings (and maybe discuss recent ones), but that feels a bit out of scope for us.
@mmarchini I agree that listing all of the issues does not make sense, I was more thinking that the TSC should be aware of significant regressions which are not going to be fixed quickly, even if they are in v8. Still not sure what the best way to address is though.
Activity
mcollina commentedon Oct 13, 2020
I'm highly aware of that issue and I do not really have a solution for it :/. Happy to discuss the story behind that.
(Note that the severe degradation was present in node-v8 last I checked).
Trott commentedon Oct 14, 2020
What do you hope greater TSC awareness will achieve?
mhdawson commentedon Oct 15, 2020
@Trott I'm thinking that the TSC should be aware of significant performance regressions affecting the LTS releases, and any which are known in advance of cutting a new Major release.
I understand that people can go search for them, but it seems to like something we should be more proactive about.
mmarchini commentedon Nov 2, 2020
I'm not sure granular awareness is relevant unless we have a plan to act on it (revert offending commits, block releases, etc.). The problem is most of the recent performance issues I've seen reported on our issue tracker are V8 related and not Node.js related, which makes it harder for us to act on it.
Preventing and fixing regressions is definitely important, but I'm wondering if a working group/task force/strategic initiative would make more sense than making the whole TSC aware. If just awareness is wanted, we can list all issues with
performancelabel on meetings (and maybe discuss recent ones), but that feels a bit out of scope for us.mhdawson commentedon Nov 2, 2020
@mmarchini I agree that listing all of the issues does not make sense, I was more thinking that the TSC should be aware of significant regressions which are not going to be fixed quickly, even if they are in v8. Still not sure what the best way to address is though.
mhdawson commentedon Jan 4, 2021
Going to close this until I come up with more concrete suggestions.