Skip to content

Backports for tsfn #358

Closed
Closed

Description

@mhdawson

Need to backport to 8.x and 10.x and make non experimental to help adoption.

Activity

  1. added this to the Milestone 11 milestone on Jan 17, 2019
  2. mhdawson commented on Jan 17, 2019

    @mhdawson
    MemberAuthor

    Gabriel - already in as experimental in 10.X

    Steps:

    1. Make non-experimental in master
    2. roll back to 10.x and 8.x

    Gabriel will get the ball rolling.

  3. gabrielschulhof commented on Jan 28, 2019

    @gabrielschulhof
    Collaborator

    v10.x backport: nodejs/node#25633
    v8.x backport: nodejs/node#25648

  4. mhdawson commented on Jan 28, 2019

    @mhdawson
    MemberAuthor

    From the meeting today sounds like there is a problem with FreeBSD 10 in the 10.x staging and release branches. Believe its the same problem that I refereed to in nodejs/node#25574.

  5. gabrielschulhof commented on Jan 28, 2019

    @gabrielschulhof
    Collaborator

    The commit on v10.x-staging that seems to have introduced the failure to compile on FreeBSD 10 is this: nodejs/node@acf7e7d

  6. gabrielschulhof commented on Mar 25, 2019

    @gabrielschulhof
    Collaborator

    These backports have now landed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions