Skip to content

access for @victorgomes to osx build bot #1920

Closed
Closed
access for @victorgomes to osx build bot#1920

Description

@MylesBorins
MylesBorins
opened on Sep 19, 2019

They are chasing down the issues in nodejs/node#29493 and want to see if they can get a patch together to get V8 7.8 working on our build machines.

Activity

  1. sam-github commented on Sep 19, 2019

    @sam-github
    sam-github
    on Sep 19, 2019
    Contributor

    @MylesBorins Is the criteria met?

    • Does the scope and size of the need justify providing access.
    • Is the individual a collaborator. If so then access should be allowed provided the first point is satisfied.
    • Length and consistency of involvement with Node.js working groups and/or community.
    • Consequences to the individual in case of misbehaviour. For example, would they potentially lose their job if they were reported as mis-behaving to their employer ? Would being banned from involvement in the Node.js community negatively affect them personally in some other way ?
    • Are there collaborators who work with the individual and can vouch for them.

    From https://github.com/nodejs/build/blob/master/doc/process/special_access_to_build_resources.md

  2. sam-github commented on Sep 19, 2019

    @sam-github
    sam-github
    on Sep 19, 2019
    Contributor

    @victorgomes

  3. MylesBorins commented on Sep 19, 2019

    @MylesBorins
    MylesBorins
    on Sep 19, 2019
    ContributorAuthor
    • Does the scope and size of the need justify providing access.

    This is to unblock the landing of V8 7.8 for Node.js 13. The work should be completed in less than a week.

    • Is the individual a collaborator. If so then access should be allowed provided the first point is satisfied.

    They Are not

    • Length and consistency of involvement with Node.js working groups and/or community.

    They are a a member of the V8 team, who was requested to handle this problem after the TSC meeting we had yesterday

    • Consequences to the individual in case of misbehaviour. For example, would they potentially lose their job if they were reported as mis-behaving to their employer ? Would being banned from involvement in the Node.js community negatively affect them personally in some other way ?

    They are an employee of Google. Misbehavior would be a risk to their employment.

    • Are there collaborators who work with the individual and can vouch for them.

    I do

  4. sam-github commented on Sep 19, 2019

    @sam-github
    sam-github
    on Sep 19, 2019
    Contributor

    That's strong enough a case I would add access immediately, except I don't have any idea how to access the OS X CI machines, and can't find any docs on them in nodejs/build. ssh didn't work, but that's not a surprise.

    @nodejs/platform-macos @nodejs/build Anyone have any ideas?

  5. mhdawson commented on Sep 19, 2019

    @mhdawson
    mhdawson
    on Sep 19, 2019
    Member

    @sam-github ssh should work, let me try.

  6. mhdawson commented on Sep 19, 2019

    @mhdawson
    mhdawson
    on Sep 19, 2019
    Member

    It works for our mac stadium 10.10 machines with this entry in the ssh config file

    Host test-macstadium-macos10.10-x64-1
  HostName 207.254.58.162
  Port 10005
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator

    I've tried with test-requireio-osx1010-x64-1, which I think the config entry should be the following based on: https://github.com/nodejs/build/pull/1890/files.

    Host test-requireio-osx1010-x64-1
  HostName 192.168.2.210
  IdentityFile ~/.ssh/nodejs_build_test
  User iojs
  ProxyCommand ssh -i ~/.ssh/nodejs_build_test -p 2222 jump@vagg-arm.nodejs.org nc -q0 %h %p

    @rvagg I still can't connect with this entry, can you see what I've got wrong?

    user1@user1-lbuntu:~/.ssh$ ssh test-requireio-osx1010-x64-1
ssh_exchange_identification: Connection closed by remote host

  7. mhdawson commented on Sep 19, 2019

    @mhdawson
    mhdawson
    on Sep 19, 2019
    Member

    @MylesBorins was test-requireio-osx1010-x64-1 chosen for a specific reason or would be ok ? test-macstadium-macos10.10-x64-1

  8. sam-github commented on Sep 19, 2019

    @sam-github
    sam-github
    on Sep 19, 2019
    Contributor

    Like @mhdawson, I can ssh into test-macstadium-macos10.10-x64-1, but not test-requireio-osx1010-x64-1:

    ssh -vvv test-requireio-osx1010-x64-1
OpenSSH_7.9p1 Ubuntu-10, OpenSSL 1.1.1b  26 Feb 2019
debug1: Reading configuration data /home/sam/.ssh/config
debug1: /home/sam/.ssh/config line 17: Applying options for *
debug1: /home/sam/.ssh/config line 802: Applying options for test-requireio-osx1010-x64-1
debug1: Reading configuration data /etc/ssh/ssh_config
debug1: /etc/ssh/ssh_config line 19: Applying options for *
debug2: resolve_canonicalize: hostname 192.168.2.210 is address
debug1: Executing proxy command: exec ssh -i ~/.ssh/ansible_ssh_private_key_file -p 2222 jump@vagg-arm.nodejs.org nc -q0 192.168.2.210 22
debug1: identity file /home/sam/.ssh/id_rsa type 0
debug1: identity file /home/sam/.ssh/id_rsa-cert type -1
debug1: identity file /home/sam/.ssh/nodejs_build_test type -1
debug1: identity file /home/sam/.ssh/nodejs_build_test-cert type -1
debug1: Local version string SSH-2.0-OpenSSH_7.9p1 Ubuntu-10
ssh_exchange_identification: Connection closed by remote host

  9. MylesBorins commented on Sep 19, 2019

    @MylesBorins
    MylesBorins
    on Sep 19, 2019 via email
    ContributorAuthor

  10. sam-github commented on Sep 20, 2019

    @sam-github
    sam-github
    on Sep 20, 2019
    Contributor

    @victorgomes which of your keys would you like me to use? there are three at https://github.com/victorgomes.keys

  11. victorgomes commented on Sep 20, 2019

    @victorgomes
    victorgomes
    on Sep 20, 2019

    @sam-github I will use the last ssh key (ending with oyUAw==).

  12. rvagg commented on Sep 20, 2019

    @rvagg
    rvagg
    on Sep 20, 2019
    Member

    Sorry, the requireio one is intentionally offline. Can be put back into service if needed but the macstadium ones seem to be going well for us.

  13. Trott commented on Sep 20, 2019

    @Trott
    Trott
    on Sep 20, 2019
    Member

    Totally-unnecessary pile-on +1 from me.

  14. sam-github commented on Sep 20, 2019

    @sam-github
    sam-github
    on Sep 20, 2019
    Contributor

    @victorgomes use this config,with identity replaced with whatever yours is:

    Host test-macstadium-macos10.10-x64-1 
  HostName 207.254.58.162
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator
  Port 10005

    Ping here when you are done and someone will remove your key (or you can remove the key then close this).

  15. victorgomes commented on Sep 22, 2019

    @victorgomes
    victorgomes
    on Sep 22, 2019

    @sam-github Thanks. I will tell you when we're done.

  16. MylesBorins
    changed the title [-]access for @victorgomes to test-requireio-osx1010-x64-1[/-] [+]access for @victorgomes to osx build bot[/+] on Sep 23, 2019

  17. MylesBorins commented on Sep 23, 2019

    @MylesBorins
    MylesBorins
    on Sep 23, 2019
    ContributorAuthor

    @mhdawson which machine do we use to build 12.x? I'm guessing it isn't 10.10... should we have given access to one of the test-macstadium-macos10.12-2 machines?

  18. targos commented on Sep 23, 2019

    @targos
    targos
    on Sep 23, 2019
    Member

    @MylesBorins releases of 12.x are built with 10.11 machines.

  19. MylesBorins commented on Sep 23, 2019

    @MylesBorins
    MylesBorins
    on Sep 23, 2019
    ContributorAuthor

    ok great. @mhdawson can we get @victorgomes access to the 10.11 machines please?

  20. sam-github commented on Sep 23, 2019

    @sam-github
    sam-github
    on Sep 23, 2019
    Contributor

    @MylesBorins @victorgomes Added your key to test-macstadium-macos10.11-x64-1, removed it from test-macstadium-macos10.10-x64-1

    Host test-macstadium-macos10.11-x64-1
  HostName 207.254.58.162
  IdentityFile ~/.ssh/nodejs_build_test
  User administrator
  Port 10003

  21. MylesBorins commented on Sep 24, 2019

    @MylesBorins
    MylesBorins
    on Sep 24, 2019
    ContributorAuthor

    We got a working build. Feel free to remove access and close issue

  22. sam-github commented on Sep 24, 2019

    @sam-github
    sam-github
    on Sep 24, 2019
    Contributor

    keys cleaned up, thanks @victorgomes

  23. sam-github
    closed this as completedon Sep 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions