Port torque_base to gyp #74

Activity

1. targos commented on Jul 25, 2018

   

   targos

   on Jul 25, 2018

   MemberAuthor

   More actions

   It doesn't seem necessary. make test-v8 passes already.
2. refack commented on Jul 25, 2018

   

   refack

   on Jul 25, 2018

   More actions

   AFAICT it's because the torque target covers these files, but we could replicate the refactoring.
   

   node-v8/deps/v8/gypfiles/v8.gyp

   Lines 2606 to 2633 in a7defdd

   	'../src/torque/ast.h',
   	'../src/torque/contextual.h',
   	'../src/torque/declarable.cc',
   	'../src/torque/declarable.h',
   	'../src/torque/declaration-visitor.cc',
   	'../src/torque/declaration-visitor.h',
   	'../src/torque/declarations.cc',
   	'../src/torque/declarations.h',
   	'../src/torque/earley-parser.cc',
   	'../src/torque/earley-parser.h',
   	'../src/torque/file-visitor.cc',
   	'../src/torque/file-visitor.h',
   	'../src/torque/global-context.h',
   	'../src/torque/implementation-visitor.cc',
   	'../src/torque/implementation-visitor.h',
   	'../src/torque/scope.cc',
   	'../src/torque/scope.h',
   	'../src/torque/source-positions.cc',
   	'../src/torque/source-positions.h',
   	'../src/torque/torque-parser.cc',
   	'../src/torque/torque-parser.h',
   	'../src/torque/torque.cc',
   	'../src/torque/type-oracle.cc',
   	'../src/torque/type-oracle.h',
   	'../src/torque/types.cc',
   	'../src/torque/types.h',
   	'../src/torque/utils.cc',
   	'../src/torque/utils.h',
3. refack commented on Sep 16, 2018

   

   refack

   on Sep 16, 2018

   More actions

   I did that as part of the builtins patch.
4. refack

   self-assigned this

   on Sep 16, 2018
5. targos commented on Oct 5, 2018

   

   targos

   on Oct 5, 2018

   MemberAuthor

   More actions

   Done in nodejs/node#22920
6. targos

   closed this as completedon Oct 5, 2018