Configure warning with Python 3.12 #50671

Activity

1. targos

   added

   pythonPRs and issues that require attention from people who are familiar with Python.PRs and issues that require attention from people who are familiar with Python.

   on Nov 11, 2023
2. targos commented on Nov 11, 2023

   

   targos

   on Nov 11, 2023

   MemberAuthor

   More actions

   There are also warnings in V8 during build (this should be fixed upstream):

   /Users/mzasso/git/nodejs/node/tools/v8_gypfiles/../../deps/v8/tools/gen-postmortem-metadata.py:747: SyntaxWarning: invalid escape sequence '\s'
     types[re.sub('\s*=.*', '', entry).lstrip()] = True;
   /Users/mzasso/git/nodejs/node/tools/v8_gypfiles/../../deps/v8/tools/gen-postmortem-metadata.py:760: SyntaxWarning: invalid escape sequence '\s'
     args = re.split('\s*,\s*', rest);
   /Users/mzasso/git/nodejs/node/tools/v8_gypfiles/../../deps/v8/tools/gen-postmortem-metadata.py:843: SyntaxWarning: invalid escape sequence '\s'
     args = re.split('\s*,\s*', rest);
   /Users/mzasso/git/nodejs/node/tools/v8_gypfiles/../../deps/v8/tools/gen-postmortem-metadata.py:942: SyntaxWarning: invalid escape sequence '\s'
     ws = re.compile('\s+')
   
3. cclauss commented on Nov 12, 2023

   

   cclauss

   on Nov 12, 2023

   Last edited by cclauss

   Contributor

   More actions

   This is a warning about Python raw strings...

   '\P' --> r'\P'
'\s' --> r'\s'

   I am high in the mountains and running out of batteries so I cannot create a pull request.

   These are Warnings, not Errors but should be fixed.
4. targos commented on Nov 12, 2023

   

   targos

   on Nov 12, 2023

   MemberAuthor

   More actions

   I can't find where the warning is coming from. There is no \P sequence in any .py file in the project.

   👍React with 👍1Reacted by Luigi Pinca
5. targos commented on Nov 13, 2023

   

   targos

   on Nov 13, 2023

   MemberAuthor

   More actions

   Our problem was in a gyp file: #50695

   V8 CL: https://chromium-review.googlesource.com/c/v8/v8/+/5018593
6. MrJithil commented on Nov 13, 2023

   

   MrJithil

   on Nov 13, 2023

   Member

   More actions

   The warning <string>:29: SyntaxWarning: invalid escape sequence '\P' is caused by the below line.

   node/deps/openssl/openssl_common.gypi

   Line 29 in 6322d4f

   'OPENSSLDIR="C:\\\Program\ Files\\\Common\ Files\\\SSL"',
7. targos commented on Nov 13, 2023

   

   targos

   on Nov 13, 2023

   MemberAuthor

   More actions

   @MrJithil Yes, that's what I fixed in #50695

   👍React with 👍1Reacted by Jithil P Ponnan
8. MrJithil commented on Nov 13, 2023

   

   MrJithil

   on Nov 13, 2023

   Last edited by MrJithil

   Member

   More actions

   We could either ignore this warning using warnings.filterwarnings

   Or we need to modify the file opening logics to read contents as raw text or proper escapes.

   Since this is coming from the dependancy, I prefer to ignore this specific warning. Because, I am confused on escaping every deps file is good or not.

   To ignore this warning
   warnings.filterwarnings("ignore", r"invalid escape sequence", category=SyntaxWarning) at the top of the configure.py
9. MrJithil commented on Nov 13, 2023

   

   MrJithil

   on Nov 13, 2023

   Last edited by MrJithil

   Member

   More actions

   I drafted this comment early today, and submitted now. Thanks for that.
10. cclauss commented on Nov 13, 2023

    

    cclauss

    on Nov 13, 2023

    Contributor

    More actions

    The warning is useful and it should not be ignored. It will become a SyntaxError in the future so let's solve instead of hide.
    https://docs.python.org/3.12/whatsnew/3.12.html#other-language-changes

    👍React with 👍1Reacted by Jithil P Ponnan
11. nodejs-github-bot

    closed this as completedin #50695on Nov 14, 2023
12. nodejs-github-bot

    added a commit that references this issue on Nov 14, 2023

    deps: escape Python strings correctly

    ...

    36ecf8c
13. targos

    added a commit that references this issue on Nov 23, 2023

    deps: escape Python strings correctly

    ...

    5d28f8d
14. UlisesGascon

    added a commit that references this issue on Dec 11, 2023

    deps: escape Python strings correctly

    ...

    b7218b4
15. UlisesGascon

    added a commit that references this issue on Dec 19, 2023

    deps: escape Python strings correctly

    ...

    3d82d38
16. richardlau

    added a commit that references this issue on Mar 19, 2024

    deps: escape Python strings correctly

    ...

    4a6f83e