test: failed on sequential/test-child-process-pass-fd #8219

Activity

1. yorkie

   added

   testIssues and PRs related to Node.js core tests and test infrastructure.Issues and PRs related to Node.js core tests and test infrastructure.

   on Aug 22, 2016
2. mscdex

   added

   child_processIssues and PRs related to the child_process subsystem.Issues and PRs related to the child_process subsystem.

   on Aug 22, 2016
3. santigimeno commented on Aug 22, 2016

   

   santigimeno

   on Aug 22, 2016

   Member

   More actions

   There's already an issue: #8209 and a PR: #8212 that tries to fix the issue.

   By the way, that commit is to fix an issue on OSX, my question is why would we test it on smartos? is it exactly right behavior?

   That commit fixed an issue on OS X by modifying when the passed descriptors are closed for every platform, so I think it makes sense to test it everywhere.
4. addaleax

   added

   duplicateIssues and PRs that are duplicates of other issues or PRs.Issues and PRs that are duplicates of other issues or PRs.

   on Aug 22, 2016
5. addaleax commented on Aug 22, 2016

   

   addaleax

   on Aug 22, 2016

   Member

   More actions

   I guess this can be closed as a duplicate then?
6. addaleax

   closed this as completedon Aug 22, 2016
7. yorkie commented on Aug 22, 2016

   

   yorkie

   on Aug 22, 2016

   ContributorAuthor

   More actions

   Thanks @santigimeno @addaleax :-)