Repository navigation
fs: allow cp() to replace a symlink with a dangling one - #66954
Open
yohannesjoya wants to merge 1 commit into
Open
yohannesjoya wants to merge 1 commit into
yohannesjoya wants to merge 1 commit into
Conversation
onLink() stat()ed the source to check whether it is a directory, which throws ENOENT when the source is a dangling symlink. Reuse srcIsDir, which is computed from the same path without throwing. Fixes: nodejs#66946 Signed-off-by: yohannesjoya <yohannesdestagebru10@gmail.com>
nodejs-github-bot
added
fs
Contributor
|
Welcome to Node.js, and thank you for your first contribution! Before review, please take a moment to read:
Please make sure every commit is signed off. For a first pull request, GitHub Actions require collaborator approval and Jenkins CI must be started by a collaborator or triager, so an initial wait is normal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fs.promises.cp()andfs.cp()failed withENOENTwhen the source is a danglingsymlink and the destination is an existing symlink.
onLink()calledstat(src)todecide whether the source is a directory before the subdirectory check, and
statfollows the dangling link. It now reuses
srcIsDir, computed a few lines earlier withinternalModuleStat(), which follows the link the same way but does not throw.Fixes: #66946
The new test fails on main and passes with this change.
tools/test.py parallel/test-fs-cp-*(91 tests) and
make lint-jspass locally.This touches the same line as #65411; whichever lands second needs a small rebase.
AI disclosure: I used a coding agent to help locate the cause and draft the test. I
reproduced the bug on a nightly build and on v22, reviewed the change line by line, and
ran the tests above locally.