Skip to content

Persist lein pids as hidden project files #83

Open

Description

@shaunlebron

This will allow us to shutdown the processes when restarting Cuttle if it crashes or a user exits.

on load:

  • check if each project has a .cuttle-lein-pid
  • kill the process
  • remove pid file

Activity

  1. oakmac commented on Jan 29, 2015

    @oakmac
    Owner

    This is an excellent idea and should simplify the shutdown code.

    On Thursday, January 29, 2015, Shaun LeBron notifications@github.com
    wrote:

    This will allow us to shutdown the processes when restarting Cuttle if it
    crashes or a user exits.

    on load:

    • check if each project has a .cuttle-lein-pid
    • kill the process
    • remove pid file

    —
    Reply to this email directly or view it on GitHub
    #83.

  2. oakmac commented on Jan 29, 2015

    @oakmac
    Owner

    On second thought - it would be a really bad idea to persist pids after the application crashes. You run the risk of cancelling the pid of some other process when restarting Cuttle. But in general I like this idea while the application is running to simplify the shutdown code.

  3. shaunlebron commented on Jan 29, 2015

    @shaunlebron
    CollaboratorAuthor

    We can inspect pids to be sure they are running lein with-profile +cuttle. And also it will keep us from have multiple Cuttle instances from trying to build the same project, though that's only really possible when running a release version alongside a dev version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions