Skip to content

You seem to have forgotten to add the qdldl code #33

Open

Description

@klaymartens

You have not actually included the updated qdldl code in your distro....so installs from pypi and even from a download are not working. I manually added the module in to test and install - that worked.

Activity

  1. klaymartens commented on Jun 16, 2023

    @klaymartens
    Author

    Correction - the files are there. They just fail to compile when installing with pip (my bad)

    Downloading the package from pypi, and then running pip install . --user gives this
    ERROR: Command errored out with exit status 1:
    command: /usr/bin/python3 /usr/lib/python3.9/site-packages/pip/_vendor/pep517/in_process/_in_process.py build_wheel /tmp/tmp_4oavvnb
    cwd: /home/mds-dc/qdldl-0.1.7
    Complete output (59 lines):
    running bdist_wheel
    running build
    running build_ext
    Traceback (most recent call last):
    File "/home/mds-dc/.local/bin/cmake", line 5, in
    from cmake import cmake
    ModuleNotFoundError: No module named 'cmake'

    But, if I run
    python3 setup install --user

    It works just fine.

  2. Jacob-Stevens-Haas commented on Feb 14, 2024

    @Jacob-Stevens-Haas

    Yeah, there's no 3.12 wheel, and cmake as a dependency is left implicit. Maintainers could add cmake to the build-system/requires table in pyproject.toml, since cmake executable is distributed as a python package as well. It would add some overhead to the build time for devs that already have cmake available on PATH, but 🤷‍♂️ but that's true of any dependency.

    Also a duplicate of #26, addressed in #31. Edit: which has now been merged :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions