Skip to content

add valkey support - #285

Open
alfaro28 wants to merge 1 commit into
pallets-eco:developmentfrom
alfaro28:development
Open

alfaro28 wants to merge 1 commit into
pallets-eco:developmentfrom
alfaro28:development

Conversation

@alfaro28

Copy link
Copy Markdown

Copy Redis implementation but using Valkey

@ThiefMaster

Copy link
Copy Markdown

Aren't redis and valkey compatible on the protocol level?

@alfaro28

Copy link
Copy Markdown
Author

yes, thats why I just copied the implementation, I'm just using the valkey library instead of the redis one

@ThiefMaster

Copy link
Copy Markdown

But... why? If the redis library can talk to valkey just fine, why not use that?

@alfaro28

Copy link
Copy Markdown
Author

well my server is valkey so I'm already using the valkey library in other parts of the code and didn't want to include the redis library just for this package

@hasansezertasan

Copy link
Copy Markdown
Member

well my server is valkey so I'm already using the valkey library in other parts of the code and didn't want to include the redis library just for this package

I am a bit confused, correct me if I am wrong. You are saying that you don't want to include redis as a dependency.

But still, you left redis as a dependency and added valkey next to it:

https://github.com/pallets-eco/flask-session/pull/285/changes#diff-50c86b7ed8ac2cf95bd48334961bf0530cdc77b5a56f852c5c61b89d735fd711R79-R80


Can't existing redis client connect to a valkey server?

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants