This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Repository navigation
This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Custom colored toolbar button icons ignore the disabled setting #1035
Description
We need to support custom colored button icons in ManageiQ, but it seems like if I have to set the opacity on the color manually if I want to have it look consistently disabled with the button text.
It looks like:
But it should look like:
Is there any way to adjust the disabled class in patternfly to apply on the custom colored fonticons?
Related BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1501114
Workaround: ManageIQ/ui-components#284
Metadata
Metadata
Assignees
Labels
No labels
Activity
terezanovotna commentedon Apr 23, 2018
@LHinson any idea who's a good person to ping about this?
LHinson commentedon Jul 5, 2018
@skateman @terezanovotna To confirm, the icons do not look disabled because of this customization? If you used the standard color, would the icon look disabled?
From a user experience perspective, I don't see any reason why edit, policy or download (as seen in the screenshot above) require a color. What value does that provide? The goal of PatternFly is to provide consistency across the various UIs, therefore I'd recommend removing this customization and opt for the PF recommended colors to align with the broader set of products.
@terezanovotna @skateman
skateman commentedon Jul 8, 2018
@LHinson the problem here is inconsistency, if the button has no custom color (i.e. has the default one) and it becomes disabled, its color will be adjusted:
terezanovotna commentedon Jul 9, 2018
@LHinson has a great point about color. It's nice to display color, but it doesn't provide any value to the user, and therefore having the icons black (for active) and grey (for disabled) makes sense.
@skateman would that resolve the issue?
skateman commentedon Jul 9, 2018
@terezanovotna @LHinson this was a requested feature by @Loicavenel
Loicavenel commentedon Jul 9, 2018
@skateman I cannot remember this, I know this was requested for Custom Button
skateman commentedon Jul 9, 2018
@Loicavenel yes, this is the custom buttons feature with custom colors. As far as I understand @terezanovotna is suggesting to drop the coloring and have all icons gray, so we don't have to deal with the opacity when disabled.
terezanovotna commentedon Jul 9, 2018
@skateman is right. Would it be a reasonable solution? @Loicavenel
Loicavenel commentedon Jul 9, 2018
@terezanovotna we introduced this feature in CF 4.6 and people really like the capability to set color on the 811 icons option, not sure we should removed a feature already supported
skateman commentedon Jul 9, 2018
So the thing I am proposing here is to adjust the definition of the
.diabledclass on a button's icon. Right now PF explicitly sets a color with the evil!important. Instead of this the opacity should be set to let's say50%on the color that is being set on the non-disabled button. This way it is not important what color is being set for the icon, it will have the disabled look & feel.Loicavenel commentedon Jul 9, 2018
Seems ok for me..
andresgalante commentedon Jul 13, 2018
Hi @skateman you are right, it should be an opacity. I have 2 concerns:
@skateman will you be able to send a PR to fix this?
skateman commentedon Jul 13, 2018
@andresgalante I was looking into this, but couldn't come up with a fix, that's why I created the issue and not a PR 😞