Repository navigation
fix(scopes): namespace data-update entry topics for scoped clients - #949
Open
BetterAndBetterII wants to merge 1 commit into
Open
BetterAndBetterII wants to merge 1 commit into
BetterAndBetterII wants to merge 1 commit into
Conversation
POST /scopes/{scope_id}/data/update rewrote entry topics as data:{topic}
and published through ScopedServerSideTopicPublisher, which prefixes
only the channel. Scoped clients filter on {scope_id}:data:{topic}, so
every entry was skipped. Prefix the payload the same way and publish
on the already-scoped topics so the channel is not double-prefixed.
✅ Deploy Preview for opal-docs canceled.
|
This was referenced Nov 6, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
POST /scopes/{scope_id}/data/updaterewrote each entry's topics asdata:{topic}and published throughScopedServerSideTopicPublisher, which prefixes only the pub/sub channel. Scoped clients subscribe to{scope_id}:data:{topic}and then skip any entry whose topics are disjoint from that set, so the update was delivered and then dropped.Prefix entry topics as
{scope_id}:data:{topic}and publish throughServerSideTopicPublisherso the channel matches the payload and is not double-prefixed.Fixes #920