Repository navigation
Conversation
Co-Authored-By: ChatGPT (GPT-6 Astra Pro)
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 9 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Thank you. The change looks right to me. Could you read the diff yourself and tick the "personally read, run and understood" box? Then please update the branch from You mention a separate problem in the zero-blend trajectory generator. Could you file an Issue for it? |
|
I have reviewed the final diff and the validation results. The branch includes |
Summary
Trajectory.plotpreviously indexed the first coast or deceleration sample even when that phase was empty, raisingIndexErrorfor valid triangular, stationary, sparsely sampled or zero-blend trajectories.Draw a phase-joining segment only when the phase contains a sample, preserving the trajectory arrays and the normal plotting path.
Numerical results and public behavior
Numerical trajectory values and public signatures are unchanged. Plotting completes when a motion phase is empty and preserves every input sample.
Regression coverage
Five phase configurations in both travel directions and with zero/nonzero time origins. The regressions check actual Matplotlib data and input immutability. Zero-blend plotting uses a real
Trajectorywith finite constant-velocity data, so the plotting check does not depend on the separate generator issue.On the unchanged original baseline, the 20 new regression cases reported 16 failures and 4 passes; all 20 pass with the fix.
Recorded focused validation
The earlier follow-up run used Linux and Python 3.12.14. The selected suites reported 51 passed, 18 subtests passed.
The result above is the previously recorded focused run. The new regression test files passed Ruff lint and formatting, and
git diff --checkpassed. Full local repository, local documentation and local cross-platform runs are outside that result.Current branch and hosted CI
The branch includes upstream
mainat879fb363580840e19ee70b6b175e8cd3543e2b38; current head:8b0c46a112d462fc327594180f33a024b7b1f903.Current-head CI is successful, including
mypy, core tests, the Linux/macOS/Windows test matrix and the documentation build. The docs-deploy and Dependabot auto-merge checks are skipped in their applicable workflow context.The separate zero-blend generator issue is tracked in #924, including the minimal reproduction and normal-blend controls.
Checklist
main.