Repository navigation
DOMDocument::xinclude(): Add a warning about untrusted input - #5862
Merged
DanielEScherzer merged 2 commits intoSep 18, 2026
Merged
Conversation
jordikroon
reviewed
Sep 17, 2026
| </para> | ||
| </note> | ||
| <warning> | ||
| <simpara> |
Member
There was a problem hiding this comment.
The parentheses make it harder to read IMO. So, how about:
Avoid calling this method on untrusted XML, as XIncludes can include files from external websites or arbitrary local files, depending on whether the href attribute is a URL or a file:// path.
Member
Author
There was a problem hiding this comment.
The "depending on" part reads a bit confusingly, since it suggests that those are the only two options
I switched to saying "when" instead of "where" after reading it with fresh eyes, but I think the parentheses are needed for clarity
ndossche
approved these changes
Sep 17, 2026
jordikroon
approved these changes
Sep 17, 2026
KentarouTakeda
added a commit
to php/doc-ja
that referenced
this pull request
Sep 25, 2026
dom の 8 ファイルを原文の変更に追従しました。これで dom モジュールの未訳・要更新はなくなります。 - PHP 8.5 で `DOMNamedNodeMap`・`DOMNodeList`・`Dom\NamedNodeMap`・`Dom\NodeList`・`Dom\HTMLCollection`・`Dom\DtdNamedNodeMap` のオブジェクトをクローンすると失敗するようになったことが、各クラスの変更履歴に追加されました。あわせて `Dom\DtdNamedNodeMap`・`Dom\HTMLCollection`・`Dom\NamedNodeMap` の説明に、似たクラスとの関係が追記されました（php/doc-en@38fcf62、php/doc-en#5877） - PHP 8.5 で `Dom\Element::getElementsByClassName()` が追加されたことが、`Dom\Element` の変更履歴に追加されました（php/doc-en@d4f96da、php/doc-en#5879） - `DOMDocument::xinclude()` に、信頼できない XML に対して使わないよう求める警告が追加されました（php/doc-en@a809316、php/doc-en#5862） ## 対象ファイル reference/dom/ (8) — domdocument/xinclude.xml, domnamednodemap.xml, domnodelist.xml, dom/dom-dtdnamednodemap.xml, dom/dom-element.xml, dom/dom-htmlcollection.xml, dom/dom-namednodemap.xml, dom/dom-nodelist.xml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.