Repository navigation
Conversation
… missing Co-authored-by: Bill Sommerfeld <129208268+Bill-Sommerfeld@users.noreply.github.com>
Bill-Sommerfeld
left a comment
Bill-Sommerfeld
left a comment
There was a problem hiding this comment.
You can credit me as Bill Sommerfeld <sommerfeld@hamachi.org>. Thanks for fixing this!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When FPM fails to start,
getPid()reports the missing PID file and returns 0, andsignal()then runskill -USR2 0. That signals the whole process group and takes down run-tests.php along with the test. Nowsignal()returns early in that case, so the test just fails and the run keeps going.Based on the reporter's patch.
Fixes #24695