[shivamhwp]

Problem

Collapse the main sidebar, quit T3 Code, open it again: the sidebar is open. The sidebar width is remembered, but the open state isn't. SidebarProvider wrote the state to a sidebar_state cookie on every toggle, nothing ever read it back, and AppSidebarLayout always passed defaultOpen. That cookie read comes from shadcn's server-rendered template; T3 Code has no server rendering, so it was never wired up.

Change

• SidebarProvider takes an optional storageKey. With it, the provider reads the saved state when it mounts and saves it on each toggle, through the same localStorage helpers the sidebar width already uses.
• AppSidebarLayout passes chat_thread_sidebar_open instead of defaultOpen. With nothing saved, the sidebar still starts open.
• The unread cookie write is gone.

The toggle button, the sidebar keyboard shortcut, the desktop menu action and settings search all go through the same setOpen, so each of them saves the state. The narrow-window sheet (openMobile) is unchanged and still starts closed. The mobile app has its own navigation and isn't affected.

Scope and approval

Closes #24191. The issue author points at this exact cause. An earlier attempt (#6643) took the same localStorage approach and was closed only because it had no manual verification, so this PR includes recordings.

Recordings (head 201d012)

Web client, collapse the sidebar, then reload. The overlay in the corner shows the step, the saved chat_thread_sidebar_open value and document.cookie.

Before (main at a46f80e): collapsed, reload, open again. Main writes sidebar_state=false and never reads it.

sidebar-main.mp4

After (this PR): collapsed, reload, still collapsed. No cookie written.

sidebar-head.mp4

Upgrade case, a user who still has the old sidebar_state=false cookie: the first load is open, the same as on main (main never read the cookie, so nothing changes for them). Collapse, reload: collapsed. Expand, reload: open. The stale cookie is ignored.

sidebar-cookie.mp4

Desktop recordings (head 201d012)

Linux desktop app (Electron dev build), empty test data. Collapse the sidebar, close the window so the app quits (the caption shows the Electron process exiting), then start the app again (a new process). The yellow line shows the sidebar state and the saved chat_thread_sidebar_open value.

Before (main at a46f80e): open again after the relaunch.

desktop-before-main.mp4

After (this PR): still collapsed after the relaunch, with chat_thread_sidebar_open = false.

desktop-after-head.mp4

Main's sidebar_state cookie never shows up in document.cookie in the desktop app, so that column reads empty in both runs.

Testing

• Head 201d012332c575ffb5c627db267936968bd6c707, physical corex (Linux), headless Chromium 1.60 (Playwright) at 1280×800, recorded with Playwright and converted to MP4 with ffmpeg.
• vp i, then vp run dev --no-seed in a fresh worktree with its own .t3 (test data only). "Before" is the same server with sidebar.tsx, AppSidebarLayout.tsx and threadSidebarWidth.ts checked out from the merge base a46f80ee28, picked up by Vite; "after" restores the PR's files.
• New browser test apps/web/src/components/ui/sidebar.browser.test.tsx: collapse, unmount, mount again, expect collapsed. It fails on main (aria-pressed is true after the remount) and passes with this change. vp run check:changed passed after the merge from main at a46f80ee28.
• Desktop recordings: head 201d012332c575ffb5c627db267936968bd6c707, corex (Linux), vp run dev:desktop --home-dir <throwaway home> in a fresh worktree, with throwaway XDG directories and a private D-Bus session, on Xvfb with openbox at 1440×900, recorded with ffmpeg x11grab. Electron got the dev launcher's own arguments plus --disable-dev-shm-usage, because corex's /dev/shm is 64 MB and nearly full, which crashed the renderer. "Before" is the same app with sidebar.tsx, AppSidebarLayout.tsx and threadSidebarWidth.ts checked out from a46f80ee28, picked up by Vite.

Not checked: macOS and Windows desktop builds. They use the same renderer code and the same localStorage path.

Made with Claude Code (Opus 5.5).

🤖 Generated with Claude Code

[macroscopeapp]

Approvability

Verdict: Approved at 5e48209

Macroscope's review found this PR approvable — This focused web fix persists the main sidebar’s explicit desktop open/collapsed choice while preserving the open default for users without saved state and leaving mobile behavior unchanged. It includes browser coverage and has no schema, infrastructure, security, or static-analysis configuration impact.

No code changes detected at 8861b51. Prior analysis still applies.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 257e407
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 6f3ebb33-50fb-416c-8ca9-7f09eab0bd88

Commits

Reviewing files that changed from the base of the PR and between c5fb8a9 and 8861b51.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• Trigger review

No actionable comments were generated in the recent review.

Walkthrough

The sidebar provider now restores and saves its open state through local storage. The thread sidebar layout supplies a storage key. Browser tests cover desktop state restoration after remount and mobile sheet behavior.

Changes: Sidebar open-state persistence

Layer / File(s)	Summary
Restore and save sidebar state apps/web/src/components/ui/sidebar.tsx	SidebarProvider accepts an optional storageKey. The provider reads a stored boolean and falls back to defaultOpen when no valid value is available. Read errors are logged. Open-state changes are saved to local storage.
Configure and verify persistence apps/web/src/components/AppSidebarLayout.tsx, apps/web/src/components/ui/sidebar.browser.test.tsx	AppSidebarLayout supplies chat_thread_sidebar_open. Browser tests check that desktop state persists after remount and that opening the mobile sheet leaves the saved desktop state unchanged. The mobile sheet is closed after remount.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: juliusmarminge, t3dotgg

Merge Risk: Minimal · previous review c5fb8

The sidebar persistence change is ready to merge after normal checks.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the fix and the affected area: the main sidebar stays collapsed after relaunch. It matches the change, which adds localStorage persistence for the sidebar open state through storageKey…
Description check		The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem and Change sections are clear. Scope links issue #24191 and explains the earlie…
Linked Issues check		Issue #24191 requires the main sidebar open state to survive reload or relaunch, the same way the sidebar width does. At head c5fb8a9, SidebarProvider accepts storageKey. createSidebarOpenStore …
Out of Scope Changes check		The whole-PR diff against merge base 4cb6945 touches apps/web/src/components/ui/sidebar.tsx and apps/web/src/components/AppSidebarLayout.tsx, plus the regression test file reported in the PR. Each…

Full details: Title check

Explanation

The title names the fix and the affected area: the main sidebar stays collapsed after relaunch. It matches the change, which adds localStorage persistence for the sidebar open state through storageKey and chat_thread_sidebar_open. It is a conventional commit title in plain language, so it passes.

Full details: Description check

Explanation

The description follows the template. It has Problem, Change, Scope and approval, and Verification sections. The Problem and Change sections are clear. Scope links issue #24191 and explains the earlier attempt. Verification gives test details, a browser test that fails on main and passes with the change, and before/after recordings for web and Linux desktop. The Scope section links the issue but does not include the maintainer approval comment the template asks for. Verification also omits the agent model and harness line, though the description does name Claude Code. The description is mostly complete, so it passes. The resolution below lists the minor gaps.

Full details: Linked Issues check

Explanation

Issue #24191 requires the main sidebar open state to survive reload or relaunch, the same way the sidebar width does. At head c5fb8a9, SidebarProvider accepts storageKey. createSidebarOpenStore initializes open from readStoredSidebarOpen(storageKey) ?? defaultOpen, which reads the value through getLocalStorageItem with Schema.Boolean. Read errors are logged and fall back to defaultOpen. setOpen calls writeLocalStorageValue(storageKey, open, defaultOpen, Schema.Boolean) on every change. AppSidebarLayout passes storageKey="chat_thread_sidebar_open" in place of defaultOpen, so the saved value applies on mount. With no saved value, the sidebar starts open. The sidebar_state cookie read and write are removed, which resolves the cause named in the issue. Because the renderer uses localStorage on web and desktop, this path also covers the Electron relaunch case. Windows 11 desktop was not checked, as the PR states. That gap is a verification gap, not a coding gap. The browser regression test is reported in the PR and is covered by the earlier review. No non-coding requirement applies to this issue.

Full details: Out of Scope Changes check

Explanation

The whole-PR diff against merge base 4cb6945 touches apps/web/src/components/ui/sidebar.tsx and apps/web/src/components/AppSidebarLayout.tsx, plus the regression test file reported in the PR. Each change supports the open-state persistence required by #24191. The sidebar.tsx changes add the storageKey prop, the read path, the localStorage write, and removal of the cookie constants and persistSidebarOpen. The AppSidebarLayout.tsx change swaps defaultOpen for storageKey. The test file covers persistence across remounts. The mobile openMobile state is not written to storage and is not changed. Width persistence is not modified. No unrelated change was found in the inspected files.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 4cb6945
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: b58d48d9-e72d-461d-b247-1e1ad5680f9a

Commits

Reviewing files that changed from the base of the PR and between 201d012 and c5fb8a9.

Files selected for processing: 3

• apps/web/src/components/AppSidebarLayout.tsx
• apps/web/src/components/ui/sidebar.browser.test.tsx
• apps/web/src/components/ui/sidebar.tsx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Dismissing prior approval to re-evaluate 5e48209

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

thanks @shivamhwp. your optional storage key, open-by-default fallback, and separate mobile state were the right approach.

i merged current main into your branch and kept your commits. persistence now lives in main's synchronous sidebar store, preserving focus handoff and drag cancellation. the write uses the existing storage helper, the one-use key is inline in the layout, and the regression coverage joins main's existing test file. the final diff is three files; the unused cookie write is gone.

verification:

• the remount regression failed against main, then all four sidebar browser tests passed.
• blacksmith vp run check:changed passed format, lint, knip, affected typechecks, and tests.
• system chrome: collapse/reload, expand/reload, and collapse/close/relaunch passed. narrow sheet opens independently and starts closed after reload; corrupt storage falls back to open.
• two independent code reviews approved 5e48209 without findings. all 31 ci checks are green; macroscope approved the current head.
• coderabbit rate-limited its latest review. macroscope and both independent reviewers approved this head.
• unverified: native electron relaunch on linux, macos, and windows. this pass exercised the shared web renderer in chrome.

before: collapse, reload, sidebar opens again on main.

after: the same thread stays collapsed after reload.

collapse and reload, with the reload's loading screen included.

[maria-rcks]

Note

Written by gpt-6.1-sol on behalf of Maria

Verified in a real dev environment

verified as-is at 5e48209273661858ead0a84bc1f8b44b062152bf on this linux boat vm. reproduced first on github/main at 9c6429d74b in a separate worktree. installed each checkout with vp i and ran one background dev server at a time, stopping main before starting the exact pr head with isolated state.

used the repo's playwright and /usr/bin/google-chrome at 1440×900 and 390×844. created the project and threads through the app, pointing at a real git repository. selected codex gpt-6.1-sol and completed real provider turns through the web composer. no mocks, fixtures, or replay data.

• main: collapse the sidebar and reload; it opens again. storage has no saved open value, and the old sidebar_state=false cookie is present.
• pr: collapse and reload; it stays collapsed with chat_thread_sidebar_open=false. expand and reload; it stays expanded with true. a fresh profile starts open.
• ctrl+b collapses the sidebar and that choice survives reload.
• at 390×844, the sidebar sheet starts closed, opens normally, and closes after reload without changing the saved desktop choice. returning to desktop restores collapsed state.
• a normal chrome process exit and restart restores collapsed state. a subsequent real codex turn completes while the sidebar remains collapsed.
• blacksmith: vp test run apps/web/src/components/ui/sidebar.browser.test.tsx passed all 4 existing tests, including resizing and persistence. the first attempt needed the worker's playwright browser installed; the rerun passed. all 33 reported head checks are successful. no source changes or pushes were needed.

runtime transcript:

main collapse -> collapsed; reload -> expanded
pr collapse -> saved false; reload -> collapsed
pr expand -> saved true; reload -> expanded
ctrl+b -> saved false; reload -> collapsed
narrow sheet open -> saved desktop false
narrow reload -> sheet closed; desktop -> collapsed
normal chrome restart -> collapsed; saved false
codex reply -> "collapsed follow-up confirmed."
sidebar after provider turn -> collapsed

matching initial conversation, before on main:

collapsed state on the pr:

main collapse and reload:

pr collapse and reload, after the additional real provider turns:

Not verified

native electron relaunch and its menu action, macos/windows builds, native ios/android clients, settings-search entry point, and remote/relay/tunnel connections were not exercised. the responsive check used the real web client, not a native mobile client. browser restart verification used normal shutdown, not crash recovery. no performance claim is made; an early app load required a reload and showed a transient vm cpu-overload notification. nothing stalled for ten minutes.