Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2423.
For a malformed (non-numeric)
amountpassed to hostedbuildOrder/createOrder, the TypeScript SDK raised the same"amount must be positive"message it uses for a genuinely non-positive numeric amount (Number("garbage")isNaN, andNaN > 0is false). The Python SDK distinguishes the two cases. This aligns TypeScript with Python's two-message scheme (the more informative of the two options in the issue):Change
sdks/typescript/pmxt/client.ts(_hostedBuildOrderBody): a finite-number guard now raisesInvalidOrder("amount must be a finite positive number")for malformed/non-finite input before the existing positivity check; theamount must be positivebranch is unchanged for finite<= 0valuesInfinityno longer leaks intoto6dec(which died with"invalid amount: Infinity")Tests
hosted buildOrder amount validationsuite (5 cases: non-numeric string, negative, zero, NaN, Infinity) — the guard runs before any network/wallet access, so all reject locallytsc --noEmitcleanAI assistance was used for this contribution (implementation and review).